From owner-freebsd-current@freebsd.org Thu Mar 23 21:39:03 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 43671D19D5B for ; Thu, 23 Mar 2017 21:39:03 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660067.outbound.protection.outlook.com [40.107.66.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DFAC31FF0; Thu, 23 Mar 2017 21:39:02 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM (10.165.218.133) by YTXPR01MB0191.CANPRD01.PROD.OUTLOOK.COM (10.165.218.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Thu, 23 Mar 2017 21:39:00 +0000 Received: from YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM ([10.165.218.133]) by YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM ([10.165.218.133]) with mapi id 15.01.0977.021; Thu, 23 Mar 2017 21:39:00 +0000 From: Rick Macklem To: Gergely Czuczy , Konstantin Belousov CC: Dimitry Andric , Ian Lepore , "FreeBSD Current" Subject: Re: process killed: text file modification Thread-Topic: process killed: text file modification Thread-Index: AQHSnqPLfXcZwdtVHkecT5jK6Yv9dKGYQJIXgAAZ/baAAFsxgIAAVqF+gAAJQ4CAAFvPgIAAF1PPgABnggCAArMZZIAAClcAgAHrwICAA2WzgIAA/q43 Date: Thu, 23 Mar 2017 21:39:00 +0000 Message-ID: References: <5ac94b9a-7ced-9eff-d746-7dddaaeca516@harmless.hu> <1489340839.40576.82.camel@freebsd.org> <20170317083605.GQ16105@kib.kiev.ua> <20170317141917.GS16105@kib.kiev.ua> <20170318032150.GW16105@kib.kiev.ua> <4642046a-08e6-35af-c76e-c5e306f01e62@harmless.hu> , <050751d5-8c4d-b257-7c83-3a9bfb38a86d@harmless.hu> In-Reply-To: <050751d5-8c4d-b257-7c83-3a9bfb38a86d@harmless.hu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: harmless.hu; dkim=none (message not signed) header.d=none;harmless.hu; dmarc=none action=none header.from=uoguelph.ca; x-microsoft-exchange-diagnostics: 1; YTXPR01MB0191; 7:lVsV3dhuUWujgTgfHVCSpVt6XQrqdhNxX5VNQwTPiBIpPfTI6sznplBlOQe4959+8iH653JEHlVWlMkBmKLfUFxdgzxWkKUIv5yJDv2OexAaig1zNIdh7tr2EQYyWWMbQP/ukI2JfaO51e2NbqhZ2i7ujqtDHYZ/PrRIpVnEfPGfCX3luVcfm99ih6U4Rf68G2iMMGVRU0glVhQXAimjhDSewdqyZB5OdYasUjeg5s/cJa59i0Cj2S5x0fKht9u2pLqleab0zhEuQE99tACk/VoC+zPl/V8kML2hgpkMzHqOeusd8gG/H3b3gcgqcgAcLvfwPXgbrpwoH/6Od3xx6g== x-ms-office365-filtering-correlation-id: a9b361d4-6c73-4d69-cdbd-08d47235048c x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075); SRVR:YTXPR01MB0191; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123558025)(20161123562025)(6072148); SRVR:YTXPR01MB0191; BCL:0; PCL:0; RULEID:; SRVR:YTXPR01MB0191; x-forefront-prvs: 0255DF69B9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39410400002)(39450400003)(39830400002)(24454002)(377454003)(55674003)(51874003)(93886004)(77096006)(2900100001)(102836003)(9686003)(55016002)(6436002)(6506006)(54906002)(53936002)(54356999)(6246003)(33656002)(39060400002)(5660300001)(76176999)(50986999)(122556002)(4326008)(38730400002)(81166006)(74482002)(2950100002)(8936002)(5890100001)(7696004)(189998001)(8676002)(97736004)(74316002)(305945005)(25786009)(53546009)(229853002)(2906002)(3660700001)(86362001)(3280700002); DIR:OUT; SFP:1101; SCL:1; SRVR:YTXPR01MB0191; H:YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; MLV:ovrnspm; PTR:InfoNoRecords; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2017 21:39:00.0481 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTXPR01MB0191 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 21:39:03 -0000 Try whatever you like. However, if the case that failed before doesn't fail= now, I'd call the test a success. Thanks, rick ps: It looks like Kostik is going to work on converting the NFS vop_putpage= s() to using the buffer cache. However, if this isn't ready for head/current= by mid-April, I will commit this patch to help fix things in the meantime. ________________________________________ From: Gergely Czuczy Sent: Thursday, March 23, 2017 2:25:11 AM To: Rick Macklem; Konstantin Belousov Cc: Dimitry Andric; Ian Lepore; FreeBSD Current Subject: Re: process killed: text file modification On 2017. 03. 21. 3:40, Rick Macklem wrote: > Gergely Czuczy wrote: > [stuff snipped] >> Actually I want to test it, but you guys are so vehemently discussing >> it, I thought it would be better to do so, once you guys settled your >> analysis on the code. Also, me not having the problem occurring, I don't >> think would mean it's solved, since that would only mean, the codepath >> for my specific usecase works. There might be other things there as >> well, what I don't hit. > I hope by vehemently, you didn't find my comments as nasty. If they did > come out that way, it was not what I intended and I apologize. > >> Let me know which patch should I test, and I will see to it in the next >> couple of days, when I get the time to do it. > I've attached it here again and, yes, I would agree that the results you = get > from testing are just another data point and not definitive. > (I'd say this statement is true of all testing of nontrivial code.) > > Thanks in advance for any testing you can do, rick > So, I've copied the patched kernel over, and apparently it's working properly. I'm not getting the error anymore. So far I've only did a quick test, should I do something more extensive, like build a couple of ports or something over NFS?