From owner-freebsd-stable@FreeBSD.ORG Thu Jan 17 07:06:28 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 1D5927A4; Thu, 17 Jan 2013 07:06:28 +0000 (UTC) (envelope-from kpaasial@gmail.com) Received: from mail-ie0-f173.google.com (mail-ie0-f173.google.com [209.85.223.173]) by mx1.freebsd.org (Postfix) with ESMTP id D5FC18D7; Thu, 17 Jan 2013 07:06:27 +0000 (UTC) Received: by mail-ie0-f173.google.com with SMTP id e13so4225330iej.4 for ; Wed, 16 Jan 2013 23:06:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=zbEE7NyGn80IrmAEimyWHj0EjgZnGvbbVxCdSgultK8=; b=FmuhtSnxDr0aXkqjkxJaFwwy+jW2DfAr7E8usu0dfu838XJHigXbZAIfj983JBFfBj NO3r+T6CzWkZ3dZ6Pe51OfERJSJoHyt+gmjdsiTaW5FXMZVzAvmADUUdnU5dV0zQ+2Am 3Wp5mLrPtHu7OyHeDF5cJe14sXgMkf5AHb70VMQEho3MI2NwGDSImdMGIMRWb0kHPiI9 utWCDEQ//ieNmjE+vZYemgemWJmGo8zmIw05rRjsJcqs8l+6G8ikQTncqHpiWWiEGLlo XMZQOjgDerIRMxQHNuduY0RYZzSGBWxKC9A8528L1w9hCth8jNgbrl0pO6b7zqoAY/uy Tccg== MIME-Version: 1.0 X-Received: by 10.50.11.193 with SMTP id s1mr2952103igb.109.1358406387172; Wed, 16 Jan 2013 23:06:27 -0800 (PST) Received: by 10.64.143.138 with HTTP; Wed, 16 Jan 2013 23:06:27 -0800 (PST) In-Reply-To: References: <50F6D20A.6070306@FreeBSD.org> Date: Thu, 17 Jan 2013 09:06:27 +0200 Message-ID: Subject: Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9 From: Kimmo Paasiala To: Dimitry Andric Content-Type: text/plain; charset=UTF-8 Cc: Brooks Davis , freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2013 07:06:28 -0000 On Wed, Jan 16, 2013 at 8:01 PM, Kimmo Paasiala wrote: > On Wed, Jan 16, 2013 at 6:15 PM, Dimitry Andric wrote: >> On 2013-01-16 13:05, Kimmo Paasiala wrote: >>> >>> I just updated my stable/9 system after clang3.2 was added. My system >>> is amd64, both world and kernel are compiled with clang3.2 and the >>> default compiler is clang. I'm tracking the sources with GIT and the >>> version I have corresponds to SVN revision r245451. >>> >>> Everything else seems to work but the pam authentication module >>> security/pam_ssh_agent_auth segfaults immediately. >> >> ... >> >>> #0 0x0000000800ef2070 in strsvis () from /lib/libc.so.7 >>> #1 0x0000000800ef2584 in strvis () from /lib/libc.so.7 >>> #2 0x0000000800ef25e5 in strnvis () from /lib/libc.so.7 >>> #3 0x0000000801c0e2e7 in do_log () from >>> /usr/local/lib/pam_ssh_agent_auth.so >>> #4 0x0000000801c0e4ff in logit () from >>> /usr/local/lib/pam_ssh_agent_auth.so >> >> ... >> >>> The str*vis() calls suggest that it's something in the libc maybe? >> >> >> Brooks merged the new strvis implementations in r245439, so you may have >> run into a bug with them. I don't think this is caused specifically by >> clang, at least not without more proof. :-) >> >> Can you try reverting to the revision just before r245439, rebuilding >> and reinstalling at least libc, and see if the pam_ssh_agent_auth crash >> goes away? > Confirmed. Reverting world to one commit before r245439 and using the version of the port I used before fixes the problem. Trying to use the version I compiled with post r245439 world results in "su: pam_start: system error" when used on pre r245439 world. I have to repeat my question, isn't this the definition of ABI breakage? -Kimmo