From owner-freebsd-current@FreeBSD.ORG Wed Aug 14 21:55:14 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A4DFBC37; Wed, 14 Aug 2013 21:55:14 +0000 (UTC) (envelope-from hiren.panchasara@gmail.com) Received: from mail-ea0-x229.google.com (mail-ea0-x229.google.com [IPv6:2a00:1450:4013:c01::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B61EB2A31; Wed, 14 Aug 2013 21:55:13 +0000 (UTC) Received: by mail-ea0-f169.google.com with SMTP id z7so10089eaf.0 for ; Wed, 14 Aug 2013 14:55:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Gzeick7puHL4MZEtYpKeWwegs4czU9pYmiia3yuxDO4=; b=BiayabqVY1CgYm+6XMgRhk9QbqXlO4G6sWM92IKDhMk25/dCGq3cxYEuMB/lAhIqSu 9/gWgwM2ldgLq7O66wPKcsh6rlbVX3VMHGHVujiAzjsQMaWVrAJjZErCAxqhuJJ7Rzwg 3bh7fu0L6ar74S/crcduKzDkqoaKXSn5+qxCtQI+VXUjIE2e6FX7bG/6ntMtqYzbql5y 6X6QzwIx/GYEeMkQSN7axhgMhxs8CIOOosdpkS0S7AoJixUUjv7hLr565G1JiiTOxUoR u+TtJsoTV8ozJvpxRUyQElSZPhepxXya7f5emjaqa89o22KfZdK7sG4FSsEiLR37BtD3 lwBg== MIME-Version: 1.0 X-Received: by 10.14.9.72 with SMTP id 48mr17129596ees.42.1376517312123; Wed, 14 Aug 2013 14:55:12 -0700 (PDT) Received: by 10.14.105.137 with HTTP; Wed, 14 Aug 2013 14:55:12 -0700 (PDT) In-Reply-To: References: Date: Wed, 14 Aug 2013 14:55:12 -0700 Message-ID: Subject: Re: patch: enable MEM_LOAD_UOPS_LLC_HIT_RETIRED on sandy bridge xeon From: hiren panchasara To: Davide Italiano Content-Type: text/plain; charset=UTF-8 Cc: Jim Harris , Adrian Chadd , freebsd-current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2013 21:55:14 -0000 2013/8/14 Davide Italiano : > On Wed, Aug 14, 2013 at 10:58 PM, Adrian Chadd wrote: >> Hi, >> >> This (and maybe more?) events are applicable to both the sandy bridge and >> sandy bridge xeon CPUs. >> >> This is from the Intel SDM June 2013 Volume #3. >> >> David/Jim, does this look fine to you? >> >> Thanks, >> >> >> ndex: sys/dev/hwpmc/hwpmc_core.c >> =================================================================== >> --- sys/dev/hwpmc/hwpmc_core.c (revision 254263) >> +++ sys/dev/hwpmc/hwpmc_core.c (working copy) >> @@ -1541,13 +1541,18 @@ >> IAP_F_SBX | IAP_F_IBX | IAP_F_HW), >> >> IAPDESCR(D2H_01H, 0xD2, 0x01, IAP_F_FM | IAP_F_CA | IAP_F_CC2 | >> - IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_IB | IAP_F_IBX | IAP_F_HW), >> + IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_SBX | IAP_F_IB | >> + IAP_F_IBX | IAP_F_HW), >> IAPDESCR(D2H_02H, 0xD2, 0x02, IAP_F_FM | IAP_F_CA | IAP_F_CC2 | >> - IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_IB | IAP_F_IBX | IAP_F_HW), >> + IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_SBX | IIAP_F_IB | >> + IAP_F_IBX | IAP_F_HW), >> IAPDESCR(D2H_04H, 0xD2, 0x04, IAP_F_FM | IAP_F_CA | IAP_F_CC2 | >> - IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_IB | IAP_F_IBX | IAP_F_HW), >> + IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_SBX | IIAP_F_IB | >> + IAP_F_IBX | IAP_F_HW), >> IAPDESCR(D2H_08H, 0xD2, 0x08, IAP_F_FM | IAP_F_CA | IAP_F_CC2 | >> - IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_IB | IAP_F_IBX | IAP_F_HW), >> + IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_SBX | IIAP_F_IB | >> + IAP_F_IBX | IAP_F_HW), >> + >> IAPDESCR(D2H_0FH, 0xD2, 0x0F, IAP_F_FM | IAP_F_CA | IAP_F_CC2 | >> IAP_F_I7 | IAP_F_WM), >> IAPDESCR(D2H_10H, 0xD2, 0x10, IAP_F_FM | IAP_F_CC2E), >> > > Yes, this looks good for me, but it's incomplete. > You need at least to put the event alias for both Sandy Bridge and > Sandy Bridge Xeon in sys/dev/hwpmc/pmc_events.h > Also, you tested the aforementioned events one by one to see if the > pmc is allocated etc...? You can use $src/tools/test/hwpmc/pmctest.py to do basic sanity test of all the available counters. cheers, Hiren > > Thanks, > > -- > Davide > > "There are no solved problems; there are only problems that are more > or less solved" -- Henri Poincare > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"