From owner-freebsd-stable@FreeBSD.ORG Tue Mar 7 16:13:29 2006 Return-Path: X-Original-To: stable@freebsd.org Delivered-To: freebsd-stable@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D1C916A423 for ; Tue, 7 Mar 2006 16:13:29 +0000 (GMT) (envelope-from kostikbel@gmail.com) Received: from fw.zoral.com.ua (ll-227.216.82.212.sovam.net.ua [212.82.216.227]) by mx1.FreeBSD.org (Postfix) with ESMTP id A31FF43D72 for ; Tue, 7 Mar 2006 16:13:19 +0000 (GMT) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by fw.zoral.com.ua (8.13.3/8.13.3) with ESMTP id k27GD0Kb069266 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 7 Mar 2006 18:13:00 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.13.4/8.13.4) with ESMTP id k27GD0ks031481; Tue, 7 Mar 2006 18:13:00 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.13.4/8.13.4/Submit) id k27GCxGX031480; Tue, 7 Mar 2006 18:12:59 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 7 Mar 2006 18:12:59 +0200 From: Kostik Belousov To: Yar Tikhiy Message-ID: <20060307161259.GG37572@deviant.kiev.zoral.com.ua> References: <44077091.3060604@freebsd.org> <80813.1141343429@thrush.ravenbrook.com> <20060306231556.GB64952@comp.chem.msu.su> <20060307101156.GF37572@deviant.kiev.zoral.com.ua> <20060307150631.GC82066@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ahP6B03r4gLOj5uD" Content-Disposition: inline In-Reply-To: <20060307150631.GC82066@comp.chem.msu.su> User-Agent: Mutt/1.4.2.1i X-Virus-Scanned: ClamAV version 0.87.1, clamav-milter version 0.87 on fw.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-1.4 required=5.0 tests=ALL_TRUSTED autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on fw.zoral.com.ua Cc: stable@freebsd.org Subject: Re: Failing to understand getrusage() X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2006 16:13:29 -0000 --ahP6B03r4gLOj5uD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 07, 2006 at 06:06:31PM +0300, Yar Tikhiy wrote: > On Tue, Mar 07, 2006 at 12:11:56PM +0200, Kostik Belousov wrote: > > On Tue, Mar 07, 2006 at 02:15:56AM +0300, Yar Tikhiy wrote: > > >=20 > > > Personally, I'd like to say a "me too". /me too fails to see why > > > in a quiet, idle system ru_maxrss is very unpredictable over numerous > > > runs of the test program, both before and after the malloc+memset. > > > Filling the memory with a non-zero value doesn't matter. Is it the > > > Heizenberg daemon at work? :-) > >=20 > > I think that this is a statclock in work :). Just add some busy loops > > before each calls to getrusage like > >=20 > > for (x =3D 0; x < 0x1000000; x++) > > getpid(); > >=20 > > and you would get statisically stable results: > >=20 > > deviant% ./1mb > > before: 424, after: 1548 > > deviant% ./1mb > > before: 424, after: 1548 > >=20 > > See, > > % sysctl kern.clockrate > > kern.clockrate: { hz =3D 1000, tick =3D 1000, profhz =3D 666, stathz = =3D 133 } > >=20 > > 133 Hz is very slow on 3GHz machine, and curproc->p_stats->p_ru is > > updated on statclock tick, see sys/kern/kern_clock.c. >=20 > This sounds very clear and reasonable. I shouldn't have forgotten > about the driving role of statclock in collecting all rusage stats, > including those related to memory consumption. >=20 It may be desirable to add ru_maxrss sampling at the calcru time too. Something like this: Index: sys/kern/kern_resource.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /usr/local/arch/ncvs/src/sys/kern/kern_resource.c,v retrieving revision 1.156 diff -u -r1.156 kern_resource.c --- sys/kern/kern_resource.c 22 Feb 2006 16:58:48 -0000 1.156 +++ sys/kern/kern_resource.c 7 Mar 2006 16:10:27 -0000 @@ -853,9 +853,16 @@ struct rusage *rup; { struct proc *p; + struct vmspace *vm; + long rss; =20 p =3D td->td_proc; PROC_LOCK(p); + vm =3D p->p_vmspace; + rss =3D pgtok(vmspace_resident_count(vm)); + if (rup->ru_maxrss < rss) + rup->ru_maxrss =3D rss; + switch (who) { =20 case RUSAGE_SELF: --ahP6B03r4gLOj5uD Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.1 (FreeBSD) iD8DBQFEDbEKC3+MBN1Mb4gRAkmPAJ0cs+ZNcIkzZsViA8D4MxfuZAH0WACfYGA8 3EsShR8TXTNvhureNSDkoro= =n0tE -----END PGP SIGNATURE----- --ahP6B03r4gLOj5uD--