From owner-freebsd-net@FreeBSD.ORG  Wed Jun 23 01:06:15 2004
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 279CD16A4CE
	for <freebsd-net@freebsd.org>; Wed, 23 Jun 2004 01:06:15 +0000 (GMT)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D6D6043D5A
	for <freebsd-net@freebsd.org>; Wed, 23 Jun 2004 01:06:14 +0000 (GMT)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i5N14ZVc063326;
	Tue, 22 Jun 2004 21:04:35 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Received: from localhost (robert@localhost)i5N14ZdQ063323;
	Tue, 22 Jun 2004 21:04:35 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Date: Tue, 22 Jun 2004 21:04:35 -0400 (EDT)
From: Robert Watson <rwatson@freebsd.org>
X-Sender: robert@fledge.watson.org
To: Bruce M Simpson <bms@spc.org>
In-Reply-To: <20040623005802.GO762@empiric.dek.spc.org>
Message-ID: <Pine.NEB.3.96L.1040622210340.61099E-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: freebsd-net@freebsd.org
Subject: Re: kern/45733: file descriptor flags and socket flags out of sync
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jun 2004 01:06:15 -0000


On Wed, 23 Jun 2004, Bruce M Simpson wrote:

> On Tue, Jun 22, 2004 at 07:11:19PM -0400, Robert Watson wrote:
> > 	so->so_state |= (head->so_state & SS_NBIO);
> 
> In the end this is what it boils down to. I've committed this and an
> appropriate manual page update. 

Since you're looking at the propagation of head so_state to new socket
so_state, you might want to look at the similar statement in sonewconn(),
which copies so_state from head to the new socket, and adds the SS_NOFDREF
flag.  Should we only be propagating SS_NBIO here as well?

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Senior Research Scientist, McAfee Research