Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 12 Aug 2013 15:15:05 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Alex Dupre <ale@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r324628 - in head/ports-mgmt/portconf: . files
Message-ID:  <20130812151505.GA54533@FreeBSD.org>
In-Reply-To: <5208F6F7.3050303@FreeBSD.org>
References:  <201308121305.r7CD58rT096600@svn.freebsd.org> <20130812132210.GA24822@FreeBSD.org> <5208E230.8010907@FreeBSD.org> <20130812134224.GB24822@FreeBSD.org> <5208F6F7.3050303@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 12, 2013 at 04:53:43PM +0200, Alex Dupre wrote:
> Alexey Dokuchaev ha scritto:
> > https://docs.google.com/presentation/d/1alWQ_dkYUoBI1BKJWI9bjQgOmtIKg5DtmCragjuOspI/edit?usp=sharing
> > 
> > Pages 8-11.
> 
> I don't see any issue, do you?

I was alarmed by the phrase "Using - (minus, dash) should be forbidden in
options names, but we're already OK here: portlint checks option's name as
\w", and lines like "LIB_DEPENDS+=apr-1:${PORTSDIR}/devel/apr1:+LDAP"; if
your commit does not prevent usages like that in the future (when/if these
features will be implemented), than I guess it's OK.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130812151505.GA54533>