From owner-freebsd-fs  Thu Apr 16 23:11:26 1998
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id XAA05391
          for freebsd-fs-outgoing; Thu, 16 Apr 1998 23:11:26 -0700 (PDT)
          (envelope-from owner-freebsd-fs@FreeBSD.ORG)
Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA05356;
          Fri, 17 Apr 1998 06:11:22 GMT
          (envelope-from julian@whistle.com)
Received: (from daemon@localhost)
	by alpo.whistle.com (8.8.5/8.8.5) id WAA28231;
	Thu, 16 Apr 1998 22:59:08 -0700 (PDT)
Received: from current1.whistle.com(207.76.205.22)
 via SMTP by alpo.whistle.com, id smtpd028229; Fri Apr 17 05:59:07 1998
Message-ID: <3536EE71.41C67EA6@whistle.com>
Date: Thu, 16 Apr 1998 22:53:53 -0700
From: Julian Elischer <julian@whistle.com>
Organization: Whistle Communications
X-Mailer: Mozilla 3.0Gold (X11; I; FreeBSD 2.2.5-RELEASE i386)
MIME-Version: 1.0
To: Michael Hancock <michaelh@cet.co.jp>
CC: freebsd-current@FreeBSD.ORG, freebsd-fs@FreeBSD.ORG
Subject: Re: Updated vfs patches
References: <Pine.SV4.3.95.980417141611.17404A-100000@parkplace.cet.co.jp>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-fs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

Michael Hancock wrote:
> 
> On Fri, 17 Apr 1998, Michael Hancock wrote:
> 
> > http://www.freebsd.org/~mch/vop1a.diff
> >
> > 1) In the original code, ext2_rmdir and msdosfs_rmdir release the lock
> > across the truncate call but ufs_rmdir doesn't.  The ufs_rmdir
> > implementation make it clean for me because I just delete the vput(), but
> > in ext2_rmdir and msdosfs_rmdir I must reacquire the lock so the generic
> > layer can do the vput() (phew!).  I'm not sure if we should be holding a
> > lock across truncate and I have yet to review the logs yet to see why.
> > Perhaps someone can shed some light on this.
> 
> I found it (POST_SOFTUPDATES)!  Do we not block when calling truncate with
> softupdates on?
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-current" in the body of the message

now THAT is a good question......
I basically took the code from kirk's changes and he seemed
(from my memory.. I don't have the changes here) to have made 
that change, so I did too. I'd have to ask kirk WHY he did that 
and he's out of town for 1 more week.

julian

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-fs" in the body of the message