Date: Thu, 16 Apr 1998 22:53:53 -0700 From: Julian Elischer <julian@whistle.com> To: Michael Hancock <michaelh@cet.co.jp> Cc: freebsd-current@FreeBSD.ORG, freebsd-fs@FreeBSD.ORG Subject: Re: Updated vfs patches Message-ID: <3536EE71.41C67EA6@whistle.com> References: <Pine.SV4.3.95.980417141611.17404A-100000@parkplace.cet.co.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
Michael Hancock wrote: > > On Fri, 17 Apr 1998, Michael Hancock wrote: > > > http://www.freebsd.org/~mch/vop1a.diff > > > > 1) In the original code, ext2_rmdir and msdosfs_rmdir release the lock > > across the truncate call but ufs_rmdir doesn't. The ufs_rmdir > > implementation make it clean for me because I just delete the vput(), but > > in ext2_rmdir and msdosfs_rmdir I must reacquire the lock so the generic > > layer can do the vput() (phew!). I'm not sure if we should be holding a > > lock across truncate and I have yet to review the logs yet to see why. > > Perhaps someone can shed some light on this. > > I found it (POST_SOFTUPDATES)! Do we not block when calling truncate with > softupdates on? > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message now THAT is a good question...... I basically took the code from kirk's changes and he seemed (from my memory.. I don't have the changes here) to have made that change, so I did too. I'd have to ask kirk WHY he did that and he's out of town for 1 more week. julian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-fs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3536EE71.41C67EA6>