Date: Tue, 09 May 2023 11:40:19 +0200 From: Corvin =?ISO-8859-1?Q?K=F6hne?= <corvink@FreeBSD.org> To: Ed Maste <emaste@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 76887e84be97 - main - cpuset: increase userland maximum size to 1024 Message-ID: <692e003e4b684c093b16048a4e12cc2dd8fc1fe0.camel@FreeBSD.org> In-Reply-To: <2f47388ab07eaeb820344e928adb96ff6f7a5916.camel@FreeBSD.org> References: <202305081826.348IQm9N040108@gitrepo.freebsd.org> <0dadaa17917629e3399fe9acbab17eb60b63575d.camel@FreeBSD.org> <2f47388ab07eaeb820344e928adb96ff6f7a5916.camel@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-5GKFb5d4tJu3UV9BqS7A Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2023-05-09 at 09:43 +0200, Corvin K=C3=B6hne wrote: > On Tue, 2023-05-09 at 08:59 +0200, Corvin K=C3=B6hne wrote: > > On Mon, 2023-05-08 at 18:26 +0000, Ed Maste wrote: > > > The branch main has been updated by emaste: > > >=20 > > > URL: > > > https://cgit.FreeBSD.org/src/commit/?id=3D76887e84be975698b14699d7d0d= fb157d73e9990 > > >=20 > > > commit 76887e84be975698b14699d7d0dfb157d73e9990 > > > Author:=C2=A0=C2=A0=C2=A0=C2=A0 Ed Maste <emaste@FreeBSD.org> > > > AuthorDate: 2023-05-02 20:57:12 +0000 > > > Commit:=C2=A0=C2=A0=C2=A0=C2=A0 Ed Maste <emaste@FreeBSD.org> > > > CommitDate: 2023-05-08 18:25:15 +0000 > > >=20 > > > =C2=A0=C2=A0=C2=A0 cpuset: increase userland maximum size to 1024 > > > =C2=A0=C2=A0=C2=A0=20 > > > =C2=A0=C2=A0=C2=A0 Hardware with more than 256 CPU cores is now avail= able and > > > will > > > become > > > =C2=A0=C2=A0=C2=A0 increasingly common.=C2=A0 Bump CPU_MAXSIZE (used = for userland > > > cpuset_t > > > =C2=A0=C2=A0=C2=A0 sizing) to 1024 to define the ABI for FreeBSD 14. > > > =C2=A0=C2=A0=C2=A0=20 > > > =C2=A0=C2=A0=C2=A0 PR:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 269572, 271213 [exp-run] > > > =C2=A0=C2=A0=C2=A0 Reviewed by:=C2=A0=C2=A0=C2=A0 mjg, jhb > > > =C2=A0=C2=A0=C2=A0 Relnotes:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 yes > > > =C2=A0=C2=A0=C2=A0 Sponsored by:=C2=A0=C2=A0 The FreeBSD Foundation > > > =C2=A0=C2=A0=C2=A0 Differential Revision: https://reviews.freebsd.org= /D39941 > > > --- > > > =C2=A0sys/sys/_cpuset.h | 2 +- > > > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) > > >=20 > > > diff --git a/sys/sys/_cpuset.h b/sys/sys/_cpuset.h > > > index b75ee595da3c..676f9855f384 100644 > > > --- a/sys/sys/_cpuset.h > > > +++ b/sys/sys/_cpuset.h > > > @@ -40,7 +40,7 @@ > > > =C2=A0#define=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0CPU_SETS= IZE=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0MAXCPU > > > =C2=A0#endif > > > =C2=A0 > > > -#define=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0CPU_MAXSIZE= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0256 > > > +#define=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0CPU_MAXSIZE= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A01024 > > > =C2=A0 > > > =C2=A0#ifndef=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0CPU_SETS= IZE > > > =C2=A0#define=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0CPU_SETS= IZE=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0CPU_MAXSIZE > >=20 > > Hi Ed, > >=20 > > this somehow breaks bhyve on my system. It immediately exits with > > "vm_run error -1" on startup. > >=20 > >=20 >=20 > Setting MAXCPU [1] to 1024 as well, solves the issue. Not sure if > it's > a regression of your commit or a bhyve bug. >=20 > [1] > https://github.com/freebsd/freebsd-src/blob/20d8d9809a8c0a3ddd1d0156e77ec= 53a1ed95747/sys/amd64/include/param.h#L68 >=20 >=20 vmm kernel module and bhyve userland are sharing a cpuset_t. So, this commit introduces a mismatch in the ioctl signature of VM_RUN. Any advice how to fix this properly, would be appreciated. [1] https://github.com/freebsd/freebsd-src/blob/c543e09f1f8ef98f201f7dd3f34ae02= 3d61dfa83/sys/amd64/include/vmm.h#L759 --=20 Kind regards, Corvin --=-5GKFb5d4tJu3UV9BqS7A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgvRSla3m2t/H2U9G2FTaVjFeAmoFAmRaFQMACgkQ2FTaVjFe AmqSgRAAsc9eC27fDMjNs3xavwGN8NNEcoR+hq8MKa8R3NqHflO73aEBcqks5K03 twvPUgr/1VehMWEN7ELssIZydEsVguFVExyUy5JdlObd8LvDIfpKeHTGh1falhXS 7uHuuaBfQb6YCQi1/+6ow9iGoQPMNmdYVaEHMwAec+Iy4lqxPlCgOQPv6YC0lGZ2 PZe8nNt3OJlMr+GsJyK/vj74a0dj9eHOWG/OL+scGN7Zgs0jwsvITIOwZyblcdx4 +a3ZLUZpj9RkbmEVc3oQzMfryJgfaGcPsWkx2XEUmt9JFcilVYeMMZ9CQJWmcyyA iqqeYaVySEaI2OiZ3qpYjGGwASoRWHcBwZMEBWxOkvjaMQr9oPeEDCgj8iFGWb5J 82LTSdq7tsSqD/7IgmqwTAU8eee8kDT4+z2b1STUzqeExGA4Mm+FqVAMN7PPmPTe cErJDXENWCVmz9QDESSu/bgVySrvI9F3JWEs3+rhfstDIAdQ6Wd3wxOa0O3IoLUV Wj3e7coVKjsVEtnyQAaLIkmNK6Izjp731ApE5D8v7eLntjdvLE8C2dZ4N2MrYc+B Ev5muvmF1kf7OwiVqkp4OF47PHTDDot44FYs4JhG74WUB1oZ1Jp6XZAwFX/tc4uW 5ynB/vLL0xx9j+DbZBSr097QnJ0c6MZWpwxfr40hKi/9EGLoiNk= =oifI -----END PGP SIGNATURE----- --=-5GKFb5d4tJu3UV9BqS7A--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?692e003e4b684c093b16048a4e12cc2dd8fc1fe0.camel>