From nobody Sat Apr 5 16:12:51 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZVL9N1QTwz5sPyb for ; Sat, 05 Apr 2025 16:12:56 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZVL9M2m7xz3CFM for ; Sat, 05 Apr 2025 16:12:55 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hardenedbsd.org header.s=google header.b=jP2TtcOA; dmarc=none; spf=pass (mx1.freebsd.org: domain of shawn.webb@hardenedbsd.org designates 2607:f8b0:4864:20::d34 as permitted sender) smtp.mailfrom=shawn.webb@hardenedbsd.org Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-855bd88ee2cso72652339f.0 for ; Sat, 05 Apr 2025 09:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; t=1743869573; x=1744474373; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2F0pHWLgpf3mosgmlHncGpHjbkslKKV1Q5caNZM7Qmg=; b=jP2TtcOAK6z5elr/3aYXqBuPccENCi4irrx81e7WvP4qMzx8Fmuhn44+Uv0K0S95MV ZLFY2erj8hLbAEdfSWJQdgVp87Rk6YRYOMKORgAqNKjgGDzQLJbjRtnEBM0hukktZmLk gnOcXJVFyEn8Xw2nWXxf3aYX6zzwPY/DQJXcyqrBhIN8sLobs1Mpg6hGOF0yUT91XbuE cL5uCPYBGyaujuHCnLyGrDyOzkirgwslJupiNA+2wwzOb7bZ9ZTn9yNQW4zHbnPm8wvF UbLB3Qu2Bs19EPv1MwGoPTnIMRjuknISnvf6uC9X66zpqZxAHeZahY5MVX3nzTWeIZE3 EhKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743869573; x=1744474373; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2F0pHWLgpf3mosgmlHncGpHjbkslKKV1Q5caNZM7Qmg=; b=mtiSwe6YQpR5joIFbqcS5XEpUp+hAP+P4IYfAdDLmnzvheDuk8khnFFhD3WRMhzlOB rP7X7LPV8UTUCphjWupC6JoQt8LUvLWDxLo5KBRHzoKNxCXdUQUVsy8vfo/5mAXHwpI5 IW4cJT04SwNjXthaPorB5XfIG+6+q9my70SlSLcwWvW1nliSRIAVYL6UhmFZ0ajO4ChK OqsoDdqcAmoBbDA5/Cs9UfR7V2fMRnGdMmztlrWnbVPAvtkpaqyW4vWaybh9Fhxe4nzq tpFvvbYRBNtbElkdIgH/v04DOCXOX9rVzsLLXqSWku3WHLQTMVg9C7rmA07cF4uqL13z 9uNw== X-Gm-Message-State: AOJu0YzteZRd3Hi5CYZzYg393PLeedt3KKAs5ry3JKaMDNguTJNKOVFf k5tNR8DT4Goae93e2GleUdUGaleQIU9FAVgM4yOxsIZ/02DL0X99aJVOclyOPY4= X-Gm-Gg: ASbGncvIEM2+avGapqi/5h9zweAr4rkMXLjavTVIixOY5hXavukXERPuezm0NN8axak qzRW1a3+smSnGIY+LEokmWSCRRm4GVevwWNcQTjbQD/KWbjGOtfmVfya8nzNGR3sulbm8EHXA6C GrlgeK4kbSptoxHQ7MHUuY7CqNcbPA20a/wdAFo+oQNKUG0e8b5pXgcKyGqC3hEa42JarbERGUd 2Dt5pSLwmth0+X+JhXRAotD8BrUsChlLPlYWgwHn1sBHoLc0CfEg8KuzhCVhAd+MfdCp4s4yxsY ccTJm/JHyAT9fjg26BpDaH9GQhqOZZ/SM1IMjg== X-Google-Smtp-Source: AGHT+IGUJQKTnZBidg0kqCHu+IVebrfiCU1EZY6Ln4OPRpTlJZC5HtLn/j/tdcnKi78vpfmaYVNuRw== X-Received: by 2002:a05:6e02:1485:b0:3d0:443d:a5c3 with SMTP id e9e14a558f8ab-3d6ec525413mr35306715ab.3.1743869573321; Sat, 05 Apr 2025 09:12:53 -0700 (PDT) Received: from mutt-hbsd ([2001:470:4001:1::95]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3d6de79f182sm14185875ab.4.2025.04.05.09.12.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Apr 2025 09:12:52 -0700 (PDT) Date: Sat, 5 Apr 2025 16:12:51 +0000 From: Shawn Webb To: Rick Macklem Cc: FreeBSD CURRENT Subject: Re: Heads Up: commit 2ec2ba7e232d just hit main Message-ID: <4beaxy5dpajikvafxpjogcxrpyuwwicng5ln5rxbxlbzp2o2g7@ib7wo5jzlte4> X-Operating-System: FreeBSD mutt-hbsd 14.2-STABLE-HBSD FreeBSD 14.2-STABLE-HBSD HARDENEDBSD-14-STABLE amd64 X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <2rq3bpvhclcipvgg3mo4gml7ysuzbvt6rfnzkprceumzeaeh4b@casrpprm6mgt> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d3gnhrcqmofn7d2v" Content-Disposition: inline In-Reply-To: X-Spamd-Result: default: False [-5.04 / 15.00]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.94)[-0.935]; MID_RHS_NOT_FQDN(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; R_DKIM_ALLOW(-0.20)[hardenedbsd.org:s=google]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_LAST(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[hardenedbsd.org:+]; ARC_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; DMARC_NA(0.00)[hardenedbsd.org]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MISSING_XM_UA(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TAGGED_RCPT(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::d34:from] X-Rspamd-Queue-Id: 4ZVL9M2m7xz3CFM X-Spamd-Bar: ----- --d3gnhrcqmofn7d2v Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: Heads Up: commit 2ec2ba7e232d just hit main MIME-Version: 1.0 On Sat, Apr 05, 2025 at 08:52:06AM -0700, Rick Macklem wrote: > On Sat, Apr 5, 2025 at 8:50=E2=80=AFAM Rick Macklem wrote: > > > > On Fri, Apr 4, 2025 at 6:27=E2=80=AFPM Shawn Webb wrote: > > > > > > On Sat, Apr 05, 2025 at 01:04:25AM +0000, Shawn Webb wrote: > > > > On Fri, Apr 04, 2025 at 05:40:21PM -0700, Rick Macklem wrote: > > > > > On Fri, Apr 4, 2025 at 10:50=E2=80=AFAM Shawn Webb wrote: > > > > > > > > > > > > On Thu, Apr 03, 2025 at 06:12:59PM -0700, Rick Macklem wrote: > > > > > > > On Thu, Apr 3, 2025 at 4:52=E2=80=AFPM Shawn Webb wrote: > > > > > > > > > > > > > > > > On Wed, Apr 02, 2025 at 01:51:26PM -0700, Rick Macklem wrot= e: > > > > > > > > > The commit 2ec2ba7e232d just hit main. I do not think it= will > > > > > > > > > cause problems, but it is fairly large. > > > > > > > > > > > > > > > > > > Man page updates will be done as separate commits. > > > > > > > > > > > > > > > > > > Hopefully this will not cause grief, rick > > > > > > > > > > > > > > > > Hey Rick, > > > > > > > > > > > > > > > > The patch review test plan mentions a patch to ZFS itself t= o support > > > > > > > > named attributes. Is that patch available somewhere? > > > > > > > The ZFS patch is currently in phabricator as D49654. > > > > > > > Feel free to review it. > > > > > > > > > > > > > > It can also be found at: > > > > > > > https://people.freebsd.org/~rmacklem/zfs-xattr.patch > > > > > > > (this is a smaller diff which can be applied to an up-to-date= main src > > > > > > > tree easily) > > > > > > > > > > > > Hey Rick, > > > > > > > > > > > > I applied that zfs patch, but trying pathconf(2) on a file on a= ZFS > > > > > > dataset with xattr=3Don (which seems to be the default) returns= 0. Am I > > > > > > doing something wrong? > > > > > > > > > > > > =3D=3D=3D=3D BEGIN LOG =3D=3D=3D=3D > > > > > > hbsd-current-01[shawn]:/home/shawn/tmp $ ./xattrtest xattrtest > > > > > > xattrtest: Named attributes not enabled: No error: 0 > > > > > > hbsd-current-01[shawn]:/home/shawn/tmp (1) $ zfs list /usr/home= /shawn > > > > > > NAME USED AVAIL REFER MOUNTPOINT > > > > > > rpool/usr/home 10.4G 71.4G 9.85G /usr/home > > > > > > hbsd-current-01[shawn]:/home/shawn/tmp $ zfs get xattr rpool/us= r/home > > > > > > NAME PROPERTY VALUE SOURCE > > > > > > rpool/usr/home xattr on default > > > > > > =3D=3D=3D=3D END LOG =3D=3D=3D=3D > > > > > > > > > > > > That xattrtest application is yours from: > > > > > > https://people.freebsd.org/~rmacklem/xattrtest.c > > > > > No idea. It works for me. You used up-to-date kernel sources? > > > > > (Check that VIRF_NAMEDATTR is defined in sys/sys/vnode.h.) > > > > > Oh, and one more thing to check. zfs_xattr_compat needs to be non= -zero. > > > > > (It's found in sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnop= s_os.c. > > > > > It's initialized to 1 and I don't see anything that sets it to 0?) > > > > > > > > It is indeed set to 1. > > > > > > > > > > > > > > The only thing I can think if is, if you changed xattr to on, you= need to > > > > > reboot (or at least remount) to get it to take effect. > > > > > (Maybe try setting it to "dir" and then reboot/remount. Maybe the= re is > > > > > a difference between "on" and "dir"?) > > > > > > > > Yeah, tried rebooting and still no go. Note that xattr defaults to > > > > "on" in FreeBSD by default. My src tree is synced up to FreeBSD com= mit > > > > 7e70d94acd68b3ac6b45f49d4ab7a0f7867c3ea7. I brought in the ZFS patch > > > > you linked to. > > > > > > > > > > > > > > Or, did you build zfs.ko some other way than as part of a kernel = build? > > > > > (It needs the patched .h files in the kernel sources, not somethi= ng in > > > > > /usr/include/sys > > > > > that has not yet been updated.) > > > > > All the ZFS changes are #ifdef'd, since OpenZFS requires the sour= ces > > > > > build for older kernels. (Basically #ifdef'd on that VIRF_NAMEDAT= TR mentioned > > > > > above.) > > > > > > > > Perhaps I need to do a clean build. I'll try that and report back. > > > > > > > > > > > > > > It does remind me that I need to try a build of zfs.ko by doing a= "make" in > > > > > the module directory. > > > > > > > > > > You can try the attached trivial patch and see if it spits out "p= athconf ret=3D1" > > > > > on the console. > > > > > > > > I'll try that after a clean rebuild of the kernel. > > > > > > Clean rebuild didn't resolve it. However, I made some progress. > > > > > > I created a dataset specifically for this since I can't really unmount > > > my /usr/home dataset, so my example down below is a bit different than > > > the previous example I gave. > > > > > > The xattr property is set to "on" for the dataset. However, it's not > > > mounted with the xattr property. In order to get it to work, I had to > > > run the following commands: > > > > > > =3D=3D=3D=3D BEGIN LOG =3D=3D=3D=3D > > > $ sudo zfs umount rpool/scratch/xattr > > > $ sudo mount -t zfs -o xattr rpool/scratch/xattr /scratch/xattr > > > $ zfs get xattr rpool/scratch/xattr > > > NAME PROPERTY VALUE SOURCE > > > rpool/scratch/xattr xattr on local > > > $ mount | grep xattr > > > rpool/scratch/xattr on /scratch/xattr (zfs, local, noatime, nfsv4acls= , named attributes) > > > $ mount | grep named > > > rpool/scratch/xattr on /scratch/xattr (zfs, local, noatime, nfsv4acls= , named attributes) > > > =3D=3D=3D=3D END LOG =3D=3D=3D=3D > > > > > > So it looks like FreeBSD does not honor the xattr zfs property, > > > otherwise you would see a whole bunch of datasets mounted with the > > > "named attributes" flag in that last `mount | grep` command. > > I've looked at this a little more... > > There is a function xattr_changed_cb() that updates the xattr property > > information. > > It gets called when "zfs set xattr=3DXX " is done or when > > the mount option "xattr" is set. > > > > The question seems to be "Why was the stuff not correctly set for your = file > > systems, although they show xattr=3Don?" This is indeed what I was inferring. xattr has been set to "on" since the pool's creation as far as I can tell. Until experimenting with your patch, I didn't really even know the xattr property even existed. > > Maybe I'll try and ask somewhere there are ZFS wizards or look in some > > OpenZFS commit logs. > > > > Have your ZFS file systems that do not have "named attribute" set been > > around for quite a while? (I'm thinking that they might have been confi= gured > > differently when they were created and never changed.) > > > > It does look like the commands (done as root) should do the same thing > > as your umount/mount did. > > # zfs set xattr=3Doff > > # zfs set xattr=3Ddir > Oh, and followed by a reboot or umount/mount without the xattr mount opti= on. The ZFS pool in the VM I'm testing was created in 2020. I would have thought that the datasets would be mounted with "named attribute" support by default since the xattr attribute is set to "on" for every single dataset. A reboot does not cause the datasets to be mounted with "named attribute" support. I had to unmount the dataset manually, then run that `mount -t zfs -o xattr ...` command manually. I suspect that the dataset automounting code paths, as performed at boot time, might need to be updated. I have zero experience with ZFS code, so my suspicion could be completely incorrect. =46rom a user's perspective, it seems that the xattr property is ignored when ZFS automounts a dataset on FreeBSD. That behavior is what is causing my suspicion above. Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --d3gnhrcqmofn7d2v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmfxVnwACgkQ/y5nonf4 4frCSA/8CC2mTgLbTOegJhHX2rBM5E/DC6CnVcnI7HYlclqK44WgwOLX7YqQq81b 6LdqPHaws/x/f9+/Bnh5GWk6GxYyCvVQ7WxTowrjlLLeC4xnqRabNLny/ODppjyy Kp7uRCXVhRIK8e3ogknMgGVlE/evHrO+eduwCtsuAMlTXGgV6OPNzPIRQIquKANF 4uykMBFFd1pfWBOx74pcE4YuOAp3CkVuhntWBoHf7LUb5lIS8N/8BXYwP8CpVP3p j9XX43oXBzgYej6+y0cACTWxpoIhfg2ehkAqLB4MAsfHVN+wXdNnFcTTSRS/9X83 4upMHa44eE+ZtfozutngVh4sIgmMxr8sQ8NysXVVJTw82RCR1dQLudH7g9CG2B54 pU6sxkWUhrjI55Mnioq4bzBs/CnyQwf0zXp5fafiv3LFDFLmzaPvVTwlcSK3Di0b G8Chq0HQMx4P1fb/Xuv6AW6DckbEfFv5zHgG0D+sEe5307FkR9pI3qkjMa7GAW0L ZhU6Wta+fTHOOiyJ1Cy1cstfn0Vdh+jS6E1IpySfUwPn6dcFpv7VadPc+WVNm+CK f7nisVlvfguISeVjysAPIUEkbhgdWHtpTY+yjgpktLmUou2i32llgfXBwtHCVNjy JPfyoLKDXIjUOjJaxJQTWTXCM3aOLPfoSQ6IBgGQcmLlctY3Fg4= =uU3w -----END PGP SIGNATURE----- --d3gnhrcqmofn7d2v--