From owner-freebsd-mips@freebsd.org  Sat Feb 25 20:12:42 2017
Return-Path: <owner-freebsd-mips@freebsd.org>
Delivered-To: freebsd-mips@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 87688CED926
 for <freebsd-mips@mailman.ysv.freebsd.org>;
 Sat, 25 Feb 2017 20:12:42 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 76A12128
 for <freebsd-mips@FreeBSD.org>; Sat, 25 Feb 2017 20:12:42 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v1PKCfvk077030
 for <freebsd-mips@FreeBSD.org>; Sat, 25 Feb 2017 20:12:42 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-mips@FreeBSD.org
Subject: [Bug 216831] [PATCH] sys/mips/cavium/octeon_machdep.c: add cavium
 octeon 'bootoctlinux' boot argument support
Date: Sat, 25 Feb 2017 20:12:42 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-STABLE
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: jmallett@FreeBSD.org
X-Bugzilla-Status: In Progress
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-mips@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-216831-27794-UmQ4muaYWP@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-216831-27794@https.bugs.freebsd.org/bugzilla/>
References: <bug-216831-27794@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-mips@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Porting FreeBSD to MIPS <freebsd-mips.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-mips>,
 <mailto:freebsd-mips-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mips/>
List-Post: <mailto:freebsd-mips@freebsd.org>
List-Help: <mailto:freebsd-mips-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
 <mailto:freebsd-mips-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Feb 2017 20:12:42 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216831

Juli Mallett <jmallett@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jmallett@FreeBSD.org

--- Comment #7 from Juli Mallett <jmallett@FreeBSD.org> ---
Hey Dave,

A couple of minor thoughts on your patch:

1. Maybe don't assume the starting argument index.  I'm pretty sure you can
pass arguments just fine even if coremask is absent, or am I misremembering=
?=20
It's been awhile since I had to deal with it, honestly.  You could easily
enough do strcmp on the n from strsep to ignore those parameters.
2. If you do want to add boothowto_parse, which is a fine idea in my opinio=
n,
please make the passed parameter const!

Thanks very much for doing this!

--=20
You are receiving this mail because:
You are the assignee for the bug.=