Date: Mon, 20 Sep 2010 08:53:19 GMT From: YIN Xiaofeng <75394094@qq.com> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/150752: be not needed to eval $_pidcmd on reboot stage Message-ID: <201009200853.o8K8rJKI063111@www.freebsd.org> Resent-Message-ID: <201009200900.o8K90FNk078700@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 150752
>Category: misc
>Synopsis: be not needed to eval $_pidcmd on reboot stage
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Sep 20 09:00:15 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: YIN Xiaofeng
>Release: 8.1-RELEASE
>Organization:
>Environment:
FreeBSD abc.xyz.com 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:55:53 UTC 2010 root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386
>Description:
If system boots normally, rc script is not necessary to determine rc_pid, and it can boot even faster. Is it right ?
>How-To-Repeat:
reboot your system, you can add one line(line: set -x ) into /etc/rc to view, and you can see _find_process (invoked by check_pidfile or check_process) to be executed.
>Fix:
--- /etc/rc.subr.orig 2010-07-19 10:24:59.000000000 +0800
+++ /etc/rc.subr 2010-09-20 16:44:26.000000000 +0800
@@ -657,7 +657,7 @@
fi
fi
- eval $_pidcmd # determine the pid if necessary
+ [ -z "$autoboot" ] && eval $_pidcmd # determine the pid if necessary
for _elem in $_keywords; do
if [ "$_elem" != "$rc_arg" ]; then
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009200853.o8K8rJKI063111>