From owner-svn-src-all@freebsd.org Thu Sep 26 23:28:13 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1D7F7136D53 for ; Thu, 26 Sep 2019 23:28:13 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46fWM03L2kz45Pt for ; Thu, 26 Sep 2019 23:28:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72d.google.com with SMTP id 201so457899qkd.13 for ; Thu, 26 Sep 2019 16:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=13stLl/C3EaKntnxDroJQvXPHLdw6xDSvpS2XTfmeac=; b=gaNxqOw+YKHjC5K/XhCAch5kR0VYnUO7NBy6DfbwgpVyWB9mUx6FXqg8KJPJb76Mrd LdpGbCr2FwWMSxEmN+JfSKhLZgMshRXzGfjU9RUGOCunNzjp7cv40/vTpc9T2/FM1/En g6X/Eh4JVBZQKJlbjnO7uGL/QF1X7yvQ4Z26aPry4ZFdifH30bTT6OSCAGkDRk7uQp3K xnQeDmTJwSOYjclvHqZ2ioiRwIwcc6VVx7J24DKWxjTUYMQOgod+8lLRynK6e3gtdsW6 LTsJo2Enihx4KBZ0N6W9mzMsCA1GZFGfeCb0zHZY/bqDuCN3xGffLifJ2jlXrn3CfdqN 5k5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=13stLl/C3EaKntnxDroJQvXPHLdw6xDSvpS2XTfmeac=; b=dqogr68HxWbGis+Ejv1b9nqI3WnJ+QifNV4Xi09EE75YCK6gIqdKMJsH8WFVrY9Hvn rZToiQfvQi/z44959CGp14Kac+7qMzUcvncl7IucyjWmjC+HH7oERVMsCFQWvppRpyeU pSwA3aitkCLFYivJrQPnGl2gYIJez+BUj/+xr8iVWdPXt8CRKIyMO7oHybtQ0LYQwHNW ZoshfKy6WkCrCL0DdyHXoiQli2WblzlJ3jDx/5AraUJ6PIToviOXwvlocNwa26bcipHE jozoCZN82H2ZPmcnwHFEMSQ+XFqqtXLGmk+Us8su7xOYF9wiDL189QZjdfU+/ZoNSQF+ /2vw== X-Gm-Message-State: APjAAAWU46epSNUnw9ct5qZash693dHP4XllMkf24C/pEzDg1vXMN6Nr D8CY0kCF4Ch5Dseb6gFa6nVkFYOAjBzncCDpd4lK2w== X-Google-Smtp-Source: APXvYqw8jlo36G3MKOOeYUwkbGm/AZe7uc32JgmUlsbPky/pKwGIyKffj5pyr8hS/4uUdRFtXyU5jLANhDW3PyQ/4HA= X-Received: by 2002:a37:6787:: with SMTP id b129mr1812695qkc.60.1569540488823; Thu, 26 Sep 2019 16:28:08 -0700 (PDT) MIME-Version: 1.0 References: <201909251826.x8PIQVUN095257@repo.freebsd.org> <605f210b-cce2-d842-cc0c-53b76ef7dbd5@vishwin.info> <1681db78-6a0c-55cf-1e01-65e06f145975@vishwin.info> <18644033-d01e-1bc7-02eb-42999033d8fd@freebsd.org> <6f50f518-0f8e-4e82-a9e9-b9db14cdb648@www.fastmail.com> <201909262008.x8QK8GPB008931@slippy.cwsent.com> In-Reply-To: <201909262008.x8QK8GPB008931@slippy.cwsent.com> From: Warner Losh Message-ID: Subject: Re: svn commit: r352707 - in head/sys: conf kern net sys To: Cy Schubert Cc: Josh Paetzel , Ryan Stone , Niclas Zeising , Charlie Li , Kyle Evans , svn-src-head , Charlie Li via svn-src-all , Gleb Smirnoff , src-committers , FreeBSD X11 mailing list X-Rspamd-Queue-Id: 46fWM03L2kz45Pt X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=gaNxqOw+; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::72d) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-2.34 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[freebsd]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; URI_COUNT_ODD(1.00)[9]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[d.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCPT_COUNT_SEVEN(0.00)[11]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.84)[ip: (-9.37), ipnet: 2607:f8b0::/32(-2.60), asn: 15169(-2.18), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; SUSPICIOUS_RECIPS(1.50)[]; RCVD_COUNT_TWO(0.00)[2] X-Mailman-Approved-At: Sat, 12 Oct 2019 23:42:15 +0000 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Thu, 26 Sep 2019 23:28:13 -0000 X-Original-Date: Thu, 26 Sep 2019 17:27:56 -0600 X-List-Received-Date: Thu, 26 Sep 2019 23:28:13 -0000 I talked to Gleb and this will move to opt_global.h. this will fix all these problems. Warner On Thu, Sep 26, 2019, 2:08 PM Cy Schubert wrote: > In message <6f50f518-0f8e-4e82-a9e9-b9db14cdb648@www.fastmail.com>, "Josh > Paetz > el" writes: > > > > > > On Thu, Sep 26, 2019, at 12:34 PM, Warner Losh wrote: > > > Kinda my point exactly... > > > > > > Warner > > > > > > On Thu, Sep 26, 2019 at 11:25 AM Ryan Stone wrote: > > >> We also shouldn't have ifdef's that change the size of a kernel > > >> structure that's part of the KBI. Isn't struct epoch_tracker part of > > >> the KBI? > > >> > > >> On Thu, Sep 26, 2019 at 12:46 PM Warner Losh wrote: > > >> > > > >> > But we shouldn't be including opt_foo.h files in sys/*.h files. > That's > > the root cause of trouble here. > > >> > > > >> > Warner > > >> > > > >> > On Thu, Sep 26, 2019 at 9:11 AM Niclas Zeising < > zeising@freebsd.org> wr > > ote: > > >> >> > > >> >> On 2019-09-26 17:03, Charlie Li via freebsd-x11 wrote: > > >> >> > Kyle Evans wrote: > > >> >> >> On Thu, Sep 26, 2019 at 9:49 AM Charlie Li wrote: > > >> >> >>> This breaks building the drm-kmod ports, as the build cannot > find > > >> >> >>> opt_epoch.h (drm-devel-kmod example shown, drm-current-kmod > dies t > > he > > >> >> >>> exact same way): > > >> >> >>> > > >> >> >>> --- linux_anon_inodes.o --- > > >> >> >>> cc -O2 -pipe -fno-strict-aliasing -include > > >> >> >>> > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/dr > > ivers/gpu/drm/drm_os_config.h > > >> >> >>> '-DKBUILD_MODNAME="linuxkpi_gplv2"' -Werror -D_KERNEL > -DKLD_MODULE > > >> >> >>> -nostdinc > > >> >> >>> > -I/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/ > > include > -I/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/lin > > uxkpi/dummy/include > > >> >> >>> > -I/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/ > > linuxkpi/gplv2/include > > >> >> >>> -I/usr/src/sys/compat/linuxkpi/common/include -I. > -I/usr/src/sys > > >> >> >>> -I/usr/src/sys/contrib/ck/include -fno-common > -fno-omit-frame-poin > > ter > > >> >> >>> -mno-omit-leaf-frame-pointer > > >> >> >>> -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include > > >> >> >>> -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -MD > > >> >> >>> -MF.depend.linux_anon_inodes.o -MTlinux_anon_inodes.o > -mcmodel=ker > > nel > > >> >> >>> -mno-red-zone -mno-mmx -mno-sse -msoft-float > > >> >> >>> -fno-asynchronous-unwind-tables -ffreestanding -fwrapv > -fstack-pro > > tector > > >> >> >>> -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes > > >> >> >>> -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef > > >> >> >>> -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ > > >> >> >>> -Wmissing-include-dirs -fdiagnostics-show-option > -Wno-unknown-prag > > mas > > >> >> >>> -Wno-error-tautological-compare -Wno-error-empty-body > > >> >> >>> -Wno-error-parentheses-equality -Wno-error-unused-function > > >> >> >>> -Wno-error-pointer-sign -Wno-error-shift-negative-value > > >> >> >>> -Wno-address-of-packed-member -Wno-format-zero-length > -Wno-pointer > > -arith > > >> >> >>> -mno-aes -mno-avx -std=iso9899:1999 -c > > >> >> >>> > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > > nuxkpi/gplv2/src/linux_anon_inodes.c > > >> >> >>> -o linux_anon_inodes.o > > >> >> >>> In file included from > > >> >> >>> > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > > nuxkpi/gplv2/src/linux_anon_inodes.c:12: > > >> >> >>> In file included from > > >> >> >>> > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > > nuxkpi/gplv2/include/linux/anon_inodes.h:4: > > >> >> >>> In file included from > > >> >> >>> > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > > nuxkpi/gplv2/include/linux/fs.h:6: > > >> >> >>> In file included from > > >> >> >>> > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > > nuxkpi/gplv2/include/linux/shrinker.h:5: > > >> >> >>> In file included from > > >> >> >>> /usr/src/sys/compat/linuxkpi/common/include/linux/list.h:56: > > >> >> >>> In file included from /usr/src/sys/net/if_var.h:83: > > >> >> >>> /usr/src/sys/sys/epoch.h:44:10: fatal error: 'opt_epoch.h' > file no > > t found > > >> >> >>> #include "opt_epoch.h" > > >> >> >>> ^~~~~~~~~~~~~ > > >> >> >>> --- linux_anon_inodefs.o --- > > >> >> >>> In file included from > > >> >> >>> > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > > nuxkpi/gplv2/src/linux_anon_inodefs.c:45: > > >> >> >>> In file included from > > >> >> >>> > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > > nuxkpi/gplv2/include/linux/debugfs.h:18: > > >> >> >>> In file included from > > >> >> >>> > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > > nuxkpi/gplv2/include/linux/fs.h:6: > > >> >> >>> In file included from > > >> >> >>> > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > > nuxkpi/gplv2/include/linux/shrinker.h:5: > > >> >> >>> In file included from > > >> >> >>> /usr/src/sys/compat/linuxkpi/common/include/linux/list.h:56: > > >> >> >>> In file included from /usr/src/sys/net/if_var.h:83: > > >> >> >>> /usr/src/sys/sys/epoch.h:44:10: fatal error: 'opt_epoch.h' > file no > > t found > > >> >> >>> #include "opt_epoch.h" > > >> >> >>> ^~~~~~~~~~~~~ > > >> >> >>> --- linux_anon_inodes.o --- > > >> >> >>> 1 error generated. > > >> >> >>> *** [linux_anon_inodes.o] Error code 1 > > >> >> >>> > > >> >> >>> make[2]: stopped in > > >> >> >>> > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > > nuxkpi > > >> >> >>> --- linux_anon_inodefs.o --- > > >> >> >>> 1 error generated. > > >> >> >>> *** [linux_anon_inodefs.o] Error code 1 > > >> >> >>> > > >> >> >>> Interestingly enough, does not happen when drm-current-kmod > is bui > > lt as > > >> >> >>> part of buildkernel (using an existing installed package with > SOUR > > CE on). > > >> >> >>> > > >> >> >> > > >> >> >> FWIW, johalun noticed this yesterday and addressed it here: > > >> >> >> > https://github.com/FreeBSDDesktop/kms-drm/commit/b486949e7e9f0cfe8d > > ac5f0ac7fe1a660300981d > > >> >> >> > > >> >> > Ah, of course I would miss these commits in the kms-drm repo, > > >> >> > considering that I watch them roll in. Will wait for the updated > > >> >> > snapshots in ports. > > >> >> > > > >> >> > > >> >> I'll get to updating the ports as soon as I can. > > >> >> Regards > > >> >> -- > > >> >> Niclas Zeising > > >> >> _______________________________________________ > > >> >> freebsd-x11@freebsd.org mailing list > > >> >> https://lists.freebsd.org/mailman/listinfo/freebsd-x11 > > >> >> To unsubscribe, send any mail to " > freebsd-x11-unsubscribe@freebsd.org" > > > > This commit broke emulators/open-vm-tools (which builds an out of tree > if_vmx > > ) > > > > Should I chase a fix for it or wait for this to get resolved in src? > > virtualbox-ose-kmod: > > --- VBoxNetFlt-freebsd.o --- > In file included from VBoxNetFlt-freebsd.c:51: > In file included from /usr/src/sys/net/if_var.h:83: > /usr/src/sys/sys/epoch.h:44:10: fatal error: 'opt_epoch.h' file not found > #include "opt_epoch.h" > ^~~~~~~~~~~~~ > 1 error generated. > *** [VBoxNetFlt-freebsd.o] Error code 1 > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: http://www.FreeBSD.org > > The need of the many outweighs the greed of the few. > > >