From owner-freebsd-current  Fri Sep 29 10: 8:21 2000
Delivered-To: freebsd-current@freebsd.org
Received: from tasogare.imasy.or.jp (tasogare.imasy.or.jp [202.227.24.5])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8325037B422; Fri, 29 Sep 2000 10:08:17 -0700 (PDT)
Received: from localhost (iwasaki.imasy.or.jp [202.227.24.92])
	by tasogare.imasy.or.jp (8.10.2+3.3W/3.7W-tasogare/smtpfeed 1.07) with ESMTP id e8TH8Er65357;
	Sat, 30 Sep 2000 02:08:14 +0900 (JST)
	(envelope-from iwasaki@jp.FreeBSD.org)
To: takawata@shidahara1.planet.sci.kobe-u.ac.jp
Cc: iwasaki@jp.freebsd.org, msmith@freebsd.org,
	acpi-jp@jp.freebsd.org, current@freebsd.org
Subject: Re: ACPI megapatch 
In-Reply-To: <200009291538.AAA20648@libr.scitec.kobe-u.ac.jp>
References: <20000930000450D.iwasaki@jp.FreeBSD.org>
	<200009291538.AAA20648@libr.scitec.kobe-u.ac.jp>
X-Mailer: Mew version 1.94.1 on Emacs 19.34 / Mule 2.3 (SUETSUMUHANA)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <20000930020812S.iwasaki@jp.FreeBSD.org>
Date: Sat, 30 Sep 2000 02:08:12 +0900
From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
X-Dispatcher: imput version 20000228(IM140)
Lines: 27
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

> >Here is a patch for your megapatch at
> >http://people.FreeBSD.org/~iwasaki/acpi/patch-for-megapatch.diff
> >I'll be happy if you accept and commit this :-)
> >
> 
> I think it is better bus attachment code is in MD part than in MI part.
> And MD bus attachment code calls MI bus attachment code.
> 
> For example,Current acpi_probe code rename to acpi_probesubr and
>  call it from acpi_probe in acpi_machdep.c . 

Hmm, I think you're talking about BI/BD.  Most of ACPI code must be
shared between IA32/IA64 (even bus interface code). Difference between
them is very limited, we can put them in acpi_machdep.c.  I like this
model.  NetBSD's pci code take this one (dev/pci/pci.c has MI code
like pcimattach(), arch/*/pci/pci_machdep.c have a set of MD
sub-routines for the specific machine architecture such as
pci_conf_read().).  I'm not sure this is correct or not, but it seems
reasonable for me.

> And probe method and identify method should not be confused.
> Memory area check etc.... can be in MD acpi probe code.

Yes, I think it's in acpi_machdep.c :-)
if not, which one?

Thanks


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message