From owner-svn-src-all@FreeBSD.ORG Mon Aug 23 08:24:01 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1828810656A5; Mon, 23 Aug 2010 08:24:01 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id C8D228FC24; Mon, 23 Aug 2010 08:24:00 +0000 (UTC) Received: from ds4.des.no (des.no [84.49.246.2]) by smtp.des.no (Postfix) with ESMTP id CB03E1FFC33; Mon, 23 Aug 2010 08:23:59 +0000 (UTC) Received: by ds4.des.no (Postfix, from userid 1001) id 98A818452E; Mon, 23 Aug 2010 10:23:59 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Dimitry Andric References: <201008141434.o7EEYaSA030301@svn.freebsd.org> <20100815205724.00007e0f@unknown> <86wrrraqk8.fsf@ds4.des.no> <4C7194E6.6080708@andric.com> Date: Mon, 23 Aug 2010 10:23:59 +0200 In-Reply-To: <4C7194E6.6080708@andric.com> (Dimitry Andric's message of "Sun, 22 Aug 2010 23:21:42 +0200") Message-ID: <86y6bxybxc.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Bruce Cran , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Bruce Evans Subject: Re: svn commit: r211304 - head/lib/libutil X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Aug 2010 08:24:01 -0000 Dimitry Andric writes: > Dag-Erling Sm=C3=B8rgrav writes: > > Bruce Cran writes: > > > Somewhat related, there are overflow bugs in humanize_number - for > > > example df(1) fails to display space from a 100PB filesystem > > > correctly. > > Patch? :) > Attached. This makes humanize_number() work properly for all possible > int64_t values. That's awesome! Any way I can convince you to fix expand_number() as well? I got a detailed explanation of what's wrong with it (both before and after my commits) from bde@ (cc:ed) in private correspondence; I can forward it to you if he doesn't mind. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no