From owner-freebsd-amd64@freebsd.org Sat Dec 3 06:57:25 2016 Return-Path: Delivered-To: freebsd-amd64@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 494FDC64121; Sat, 3 Dec 2016 06:57:25 +0000 (UTC) (envelope-from woodsb02@gmail.com) Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0FFD4BD0; Sat, 3 Dec 2016 06:57:25 +0000 (UTC) (envelope-from woodsb02@gmail.com) Received: by mail-io0-x22d.google.com with SMTP id m5so381506783ioe.3; Fri, 02 Dec 2016 22:57:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9QzwDbl5calEjqEEMAErKeGN1StJQ2YCBxcA/wkjhIM=; b=Jg+2k/ALQxpqJAAkplNaat7C03yV8zY7nqOo09NTDFXDyRcmEPo4fWqCjt25W4/8Ex n9dlDfsKjCCXZ+FfQf6u3g6DrotPamAGrrzfMAU7O5shsR9pJFyPJo44g5uz5OL32qFv baV3pruYn54b2vxeynIEtke7CBtoq5c+oUUvZ2Reg9AzFZ/Cn+9PJz9CDg2yPsGH/q6o pDgtMNXx3qM/F0Ty3Xs6NOo/EGQ0S2CWoKvENGZzKg5N8WcdllMKM3ZN59cvqS1zI74c 6MI5ioYbt/JShCXrSg/FHiVp4uaWcmaudGjOkN+m2DYMEm2QIxVG3kejlxKXLudCLZ3q ig/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9QzwDbl5calEjqEEMAErKeGN1StJQ2YCBxcA/wkjhIM=; b=LP+Xpx+BVtfUyGe7G15XD6mC/iZODju5Ad50vbWhM/DH3JzcdvmnwvEhgEAcSHBZZy 5zhK5EsiHIAkhcq6zDza6d+u8VeWomwskfWNiThS0sqn05C8ZWJkuoz1IUKdl7iPIW4M vXOxmnFd0dDgw6LJgbTbHFQ/9JVA8WZBCSaencYqvtt/+PPjYm+ajwcqtSJhknd1pacV fsK/+c+qeWsRNzO+P/rLW54hN387Pdvhwb926DcmEIrecFxJhs6mnMyqMZtEX3OE5uNi e3muLSfOunMcwi7S7rzkFqUqY4sfdlHKm3dBb75lbYp5eoCogfVbpEczWq3JIxAVoQr+ If+g== X-Gm-Message-State: AKaTC02rJIKJu5Jklwkhio/CBko2O3QVnS4lqnSagtfkOAdz7BF63l7NLMuabrS10FZbNoaMyF34pV2zY81i2w== X-Received: by 10.36.58.85 with SMTP id m82mr754844itm.29.1480748244476; Fri, 02 Dec 2016 22:57:24 -0800 (PST) MIME-Version: 1.0 Received: by 10.79.136.197 with HTTP; Fri, 2 Dec 2016 22:57:24 -0800 (PST) In-Reply-To: References: From: Ben Woods Date: Sat, 3 Dec 2016 14:57:24 +0800 Message-ID: Subject: Re: CFT EFI Boot Refactoring To: Eric McCorkle Cc: freebsd-hackers@freebsd.org, freebsd-amd64@freebsd.org, "current@freebsd.org" X-Mailman-Approved-At: Sat, 03 Dec 2016 12:59:30 +0000 Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Dec 2016 06:57:25 -0000 On 3 December 2016 at 14:40, Ben Woods wrote: > I just applied your diff to my subversion repository, and tried to > buildworld, but the build failed with the following error: > > make[6]: make[6]: don't know how to make efipart.c. Stop > > make[6]: stopped in /usr/src/sys/boot/efi/drivers > *** [all_subdir_sys/boot/efi/drivers] Error code 2 > > > Does it build ok for you? > > Because I use subversion, and I wanted to build it from my main tree, I > had to regenerate your patch using "git diff --no-prefix > master..origin/efize_new > /tmp/efize_new.diff". > I could then apply this cleanly with "svn patch /tmp/efize_new.diff". > > Never mind, I have realised that efipart.c was moved from boot/efi/libefi/ to boot/efi/drivers/ in your git patch, but subversion did not interpret this change and simply patched the file in place. I have fixed this with: $ svn mv boot/efi/libefi/efipart.c boot/efi/drivers/efipart.c Sorry for the noise (and the previous top post). Regards, Ben -- From: Benjamin Woods woodsb02@gmail.com