From owner-freebsd-x11@freebsd.org Fri Sep 27 04:43:31 2019 Return-Path: Delivered-To: freebsd-x11@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2124DF5BF3; Fri, 27 Sep 2019 04:43:31 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ffLn6xl6z4LkV; Fri, 27 Sep 2019 04:43:29 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg1-x543.google.com with SMTP id s1so2750978pgv.8; Thu, 26 Sep 2019 21:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/Dfcvg8feGmjdOBbfx/24hbNfewC2V3luFlWEKEDBf0=; b=VBMxiTgLL8IJGo66vBY4EBv7HRf4K6hKjQAiDH3ZkM0Wmn3V+6oFs46NkeyqbovHLF yiUh4N/MGvlMY7tbdZN8mbk5BmgZ2HDlQZSmcScD0/z41aMrqsvCjTWkm7JGwnJMqpqM IC5s9E5annCNIxqbvQEC17WUEDmfvweVektillfJgkV44xE5CeHm3iIMCRhCOh/bkKHY wCI7TiIBUQrXf82sAK8hmgNy0mnc/ykJc7J6DEfSPQe3bjXGfz4/vM/GsEnpcyttxv18 XBRbNFuw3oOfEKtLuqgpGW2hpKX6X/1wXulFEQDNAHBUXHf7KsXBz3PQNLu1AZ0yxZob mrFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=/Dfcvg8feGmjdOBbfx/24hbNfewC2V3luFlWEKEDBf0=; b=Sj9AwHEOiqSPu/drJjFEV9jDaM/k5/6eOuAgEwFXOA2AjG9tiZmQpbAiDMDyMUzuLD 3w5cgr4PeuLPjKj/qk7mXu4JYJ361xIl6m+wmlHojtLhXsLxx3lddtr54RWgudx03v2I hfzMKpw3tC8wNYhy/ijWt/q1hZYKL9OhVwvxu8u6lqZvi4WTi52be31I5dthPkFY6WsQ ud0uCBOIXq1um4Uqad2l+URSLmoRilgtqOysNrXotmxlvpyS2jnv0cNwuybHXJSmm2Mf 4KDDarFyhoET3aOdUxLEXf11w7nye9beT+n05Ogti+mRoagZNmhiK2L/wkbcNI452PsY bC4g== X-Gm-Message-State: APjAAAU2LfutxsBx0P/avbXx1PIMDSKzAD+aZr1ws6gRTLNIwz3UjBXb DkglbMoWLhg5WevBOfMl4J49lcnY X-Google-Smtp-Source: APXvYqw83lfVjhz54MxzKw4hIuQ5X9v8KYHMz0vbVTOXl5NYjphOUFjLu0jDre9j1fl5g0IzaktbYA== X-Received: by 2002:a65:64c6:: with SMTP id t6mr7285947pgv.323.1569559407646; Thu, 26 Sep 2019 21:43:27 -0700 (PDT) Received: from ?IPv6:2403:5800:7100:5d01:f1f4:9e96:4fb0:fb4a? (2403-5800-7100-5d01-f1f4-9e96-4fb0-fb4a.ip6.aussiebb.net. [2403:5800:7100:5d01:f1f4:9e96:4fb0:fb4a]) by smtp.gmail.com with ESMTPSA id q21sm563845pgm.27.2019.09.26.21.43.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Sep 2019 21:43:27 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r352707 - in head/sys: conf kern net sys To: Charlie Li , Gleb Smirnoff , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: freebsd-x11@freebsd.org References: <201909251826.x8PIQVUN095257@repo.freebsd.org> <605f210b-cce2-d842-cc0c-53b76ef7dbd5@vishwin.info> From: Kubilay Kocak Message-ID: <698b5ba8-359c-05e7-0f66-7d1cb980243a@FreeBSD.org> Date: Fri, 27 Sep 2019 14:43:22 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Thunderbird/70.0 MIME-Version: 1.0 In-Reply-To: <605f210b-cce2-d842-cc0c-53b76ef7dbd5@vishwin.info> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46ffLn6xl6z4LkV X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=VBMxiTgL; dmarc=none; spf=pass (mx1.freebsd.org: domain of koobsfreebsd@gmail.com designates 2607:f8b0:4864:20::543 as permitted sender) smtp.mailfrom=koobsfreebsd@gmail.com X-Spamd-Result: default: False [-1.82 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[koobs@FreeBSD.org]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; FORGED_SENDER(0.30)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; TAGGED_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[freebsd]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.4.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.12)[ip: (-0.77), ipnet: 2607:f8b0::/32(-2.60), asn: 15169(-2.18), country: US(-0.05)]; RCVD_TLS_ALL(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Sep 2019 04:43:31 -0000 On 27/09/2019 12:48 am, Charlie Li via svn-src-head wrote: > Gleb Smirnoff wrote: >> Modified: head/sys/conf/options >> ============================================================================== >> --- head/sys/conf/options Wed Sep 25 18:09:19 2019 (r352706) >> +++ head/sys/conf/options Wed Sep 25 18:26:31 2019 (r352707) >> @@ -712,6 +712,8 @@ WITNESS_SKIPSPIN opt_witness.h >> WITNESS_COUNT opt_witness.h >> OPENSOLARIS_WITNESS opt_global.h >> >> +EPOCH_TRACE opt_epoch.h >> + >> # options for ACPI support >> ACPI_DEBUG opt_acpi.h >> ACPI_MAX_TASKS opt_acpi.h >> >> Modified: head/sys/sys/epoch.h >> ============================================================================== >> --- head/sys/sys/epoch.h Wed Sep 25 18:09:19 2019 (r352706) >> +++ head/sys/sys/epoch.h Wed Sep 25 18:26:31 2019 (r352707) >> @@ -41,6 +41,8 @@ typedef struct epoch_context *epoch_context_t; >> #include >> #include >> >> +#include "opt_epoch.h" >> + >> struct epoch; >> typedef struct epoch *epoch_t; >> > This breaks building the drm-kmod ports, as the build cannot find > opt_epoch.h (drm-devel-kmod example shown, drm-current-kmod dies the > exact same way): I started to get pkg-fallout emails in net/aquantia-atlantic-kmod with the same build failure https://github.com/Aquantia/aqtion-freebsd/issues/4 > --- linux_anon_inodes.o --- > cc -O2 -pipe -fno-strict-aliasing -include > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/drivers/gpu/drm/drm_os_config.h > '-DKBUILD_MODNAME="linuxkpi_gplv2"' -Werror -D_KERNEL -DKLD_MODULE > -nostdinc > -I/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/include -I/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/dummy/include > -I/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include > -I/usr/src/sys/compat/linuxkpi/common/include -I. -I/usr/src/sys > -I/usr/src/sys/contrib/ck/include -fno-common -fno-omit-frame-pointer > -mno-omit-leaf-frame-pointer > -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include > -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -MD > -MF.depend.linux_anon_inodes.o -MTlinux_anon_inodes.o -mcmodel=kernel > -mno-red-zone -mno-mmx -mno-sse -msoft-float > -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector > -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes > -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef > -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ > -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas > -Wno-error-tautological-compare -Wno-error-empty-body > -Wno-error-parentheses-equality -Wno-error-unused-function > -Wno-error-pointer-sign -Wno-error-shift-negative-value > -Wno-address-of-packed-member -Wno-format-zero-length -Wno-pointer-arith > -mno-aes -mno-avx -std=iso9899:1999 -c > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/src/linux_anon_inodes.c > -o linux_anon_inodes.o > In file included from > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/src/linux_anon_inodes.c:12: > In file included from > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/anon_inodes.h:4: > In file included from > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/fs.h:6: > In file included from > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/shrinker.h:5: > In file included from > /usr/src/sys/compat/linuxkpi/common/include/linux/list.h:56: > In file included from /usr/src/sys/net/if_var.h:83: > /usr/src/sys/sys/epoch.h:44:10: fatal error: 'opt_epoch.h' file not found > #include "opt_epoch.h" > ^~~~~~~~~~~~~ > --- linux_anon_inodefs.o --- > In file included from > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/src/linux_anon_inodefs.c:45: > In file included from > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/debugfs.h:18: > In file included from > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/fs.h:6: > In file included from > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/shrinker.h:5: > In file included from > /usr/src/sys/compat/linuxkpi/common/include/linux/list.h:56: > In file included from /usr/src/sys/net/if_var.h:83: > /usr/src/sys/sys/epoch.h:44:10: fatal error: 'opt_epoch.h' file not found > #include "opt_epoch.h" > ^~~~~~~~~~~~~ > --- linux_anon_inodes.o --- > 1 error generated. > *** [linux_anon_inodes.o] Error code 1 > > make[2]: stopped in > /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi > --- linux_anon_inodefs.o --- > 1 error generated. > *** [linux_anon_inodefs.o] Error code 1 > > Interestingly enough, does not happen when drm-current-kmod is built as > part of buildkernel (using an existing installed package with SOURCE on). >