From owner-freebsd-gnome@FreeBSD.ORG Tue Jun 8 18:49:35 2004 Return-Path: Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5162816A4CE for ; Tue, 8 Jun 2004 18:49:35 +0000 (GMT) Received: from lakermmtao07.cox.net (lakermmtao07.cox.net [68.230.240.32]) by mx1.FreeBSD.org (Postfix) with ESMTP id ABEBD43D45 for ; Tue, 8 Jun 2004 18:49:34 +0000 (GMT) (envelope-from mezz7@cox.net) Received: from mezz ([68.103.32.140]) by lakermmtao07.cox.net (InterMail vM.6.01.03.02 201-2131-111-104-20040324) with ESMTP id <20040608184933.SUBS10348.lakermmtao07.cox.net@mezz>; Tue, 8 Jun 2004 14:49:33 -0400 To: "Joe Marcus Clarke" References: <1086719776.68846.35.camel@shumai.marcuscom.com> Message-ID: From: "Jeremy Messenger" Content-Type: text/plain; format=flowed; delsp=yes; charset=iso-8859-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Date: Tue, 08 Jun 2004 13:50:24 -0500 In-Reply-To: <1086719776.68846.35.camel@shumai.marcuscom.com> User-Agent: Opera M2/7.51 (Linux, build 689) cc: freebsd-gnome@freebsd.org Subject: Re: Need feedback/review, a big change in AbiWord2 port. X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 18:49:35 -0000 On Tue, 08 Jun 2004 14:36:16 -0400, Joe Marcus Clarke wrote: > On Tue, 2004-06-08 at 03:01, Jeremy Messenger wrote: >> On Tue, 08 Jun 2004 01:09:56 -0500, Jeremy Messenger >> wrote: >> >> > Hello, >> > >> > I have maken a big changes in AbiWord2 port, what I have done: >> > >> > - Clean up to make it looks nicer. >> > - Change from autogen.sh to configure; it works fine with tweaks. >> > - No longer wv check for the conflict, which it depends on >> textproc/wv >> > rather than the one include AbiWord's tarball. I have tested my Mom >> > and sister's docs from their work/school and they works fine with >> wv >> > port. I don't see any problem or slowdown. >> > - Force AbiWord to check/compile everything what apps that are >> > installed (headers, libraries, etc) from ports rather than check >> and >> > use the stuff that are included in tarball such as wv, zlib, >> libpng, >> > popt and etc. >> > - Change the default spell from Enchant to Aspell, because it doesn't >> > work at all unless you compile Enchant with the Aspell support. I >> > think, it's waste to depend on Enchant by default. >> > >> > Also, I have removed the check of Enchant. I prefer to see force >> > user to want use Enchant if they know what to do with it. I need >> the >> > help on write the better comment in @${ECHO_CMD} about this. >> > - Add the new WITHOUT_GTKSPELL knob to allow us not depend and >> install >> > either Aspell or Enchant, but the spell checker will be still >> enable >> > and dictionary will be install. The spell checker works fine in my >> > test so far. >> > - Add the new WITH_HTML_HELP_BROWSER knob to allow us install the >> Help >> > docs. This cover the ports/66623, but I personal still would like >> to >> > see use the DOCSDIR path. >> >> I have changed this part. Now, this is enable by default and change the >> knob name to WITHOUT_HELP_DOCS. Also, I did the more small clean up and >> bump the PORTREVISION. All that was from marcus's feedback. > > You're still use HELPBROWSER for a PLIST_SUB. This should be changed. Done, now it's HELPDOCS. Thanks! Cheers, Mezz > Joe > >> >> > The vote is still open for if you dislike put Help docs in Makefile >> > and rather to create a seperate port, just give a shout. >> > >> > Vote: >> > =================================== >> > mezz = Makefile >> > marcus = seperate port, unless Makefile doesn't turn into mess. >> > =================================== >> > >> > At last, here's diff: >> http://people.freebsd.org/~mezz/diff/AbiWord2.diff >> >> Updated a new diff in the same place. >> >> Cheers, >> Mezz >> >> > After collect the feedbacks and commit, I will try to take the look at >> > create a new spereate port for AbiWord2 plugins. >> > >> > I think, that's all for now. /me goes to grab some beers and take the >> > break. >> > >> > Cheers, >> > Mezz -- mezz7@cox.net - mezz@FreeBSD.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org