From owner-svn-src-head@freebsd.org Tue Dec 12 19:22:53 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 90382E81177 for ; Tue, 12 Dec 2017 19:22:53 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 515B16D7CA for ; Tue, 12 Dec 2017 19:22:53 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x230.google.com with SMTP id w127so159796iow.11 for ; Tue, 12 Dec 2017 11:22:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=cZYMYyG1g/b7V6MfaCnHNR9NWsxjvzRPde72umrEtuU=; b=kcC9f+bc2NB+wppq4snQpw2u8VzKDVpArlNhEIZq6hI1VHfzrB/7m7wkY6sjDzlrPa oaW7kuh/Kgl3Vp9NWh6Ctj/AGqRi/qYkOaQkfMDlOPs0MHul6i2vI5DcrkkawIa4esDn 6KxJpxpYYoVwa/EhGWB5lh+no06QV8E7mqIAzlFF0HTaictEBOr5ct44sW5MNxvH+YEg vh235Rw95SXcLF2fmpqjrsamd6Xj9YDTeu6SZQho8tuHEn9mOdjRsn7ZrSYpnT/9ataM 03baBSK9V+cd5rH40qbesSIoQF2XjK7tqQKsYtNzGzVR6kFawJ8PcrzEWlnX1PW4YMLK u+5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=cZYMYyG1g/b7V6MfaCnHNR9NWsxjvzRPde72umrEtuU=; b=GA1qWSvarkhoHFm0PqIJQBeQ3OaqlBggG9G4g15GrcwuJw8GNY0oIDNnRRYulL4XFU lqyAt0KMFUdLwZFuCY2JscOCR4npVq9DNEtUlRaIun7BotCm020RSd8VKqh1GSanlQmd Csu532QKV0AH/w8ckojBkFZZozKSOzH5pOGP4aHy6ngcsNmjcQ0Am+d6f7CeA4918GI/ P1GhXVjg6Fi+/htlqw90ST289l41UxQ7VWsPGwgDFlcBMakCSt4ToxSbb4Q7TFysJk8j WNUdlN/U/lZjuiT4gzvX7gOGBlue1tT8TVLJFVRDOC3r3lktcivLjT74M6bntTbl8gNK OUrw== X-Gm-Message-State: AKGB3mIz+gFNY/JvcU5ppL/kt++GrjVglu0nXEKiYSwPrQgYeGwUkMBc XNS6bfjwuOkbQFHN86+y9sqXayYp8WrBLKI+6O2Jzg== X-Google-Smtp-Source: ACJfBotbq4Pg+T6Ubb+1FFwJLlZDvNzJ200HAPe4g0NSGwiWFTLR2wKrqOmzF/a8sDR7DlcruxzvPRJmzcdsAOJbaQo= X-Received: by 10.107.30.81 with SMTP id e78mr6360274ioe.130.1513106572456; Tue, 12 Dec 2017 11:22:52 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Tue, 12 Dec 2017 11:22:51 -0800 (PST) X-Originating-IP: [12.227.204.186] In-Reply-To: References: <201712120946.vBC9krNL075725@repo.freebsd.org> From: Warner Losh Date: Tue, 12 Dec 2017 12:22:51 -0700 X-Google-Sender-Auth: 4U6L1Mff-MVFu7XP1IrS2HbbFtM Message-ID: Subject: Re: svn commit: r326792 - head/stand/uboot/common To: Mateusz Guzik Cc: Antoine Brodin , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , src-committers Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 19:22:53 -0000 On Tue, Dec 12, 2017 at 12:13 PM, Mateusz Guzik wrote: > How about you both close one PR as a punishment and we pretend this did > not happen. > I'll fix 6 CIDs as punishment. Warner > The thing to do was to reply to the offending commit or contact the > committer > on irc. Only in case of no timely response fixing on your own is the right > thing > to do. > > > On Tue, Dec 12, 2017 at 8:03 PM, Warner Losh wrote: > >> The email I wrote here also sucks. It was unduly harsh. While the commit >> message should have been better, I was too harsh in trying to express this >> and giving a better example. >> >> Warner >> >> On Tue, Dec 12, 2017 at 5:49 AM, Warner Losh wrote: >> >> > This commit message sucks. Please use a more descriptive one in the >> future >> > like "catch up to change rXXXXX that remove the argument from >> interact." If >> > you want to be snarky, add 'pounty hat to imp' to it. Thats infornative. >> > Your message is utterly useless. It doesn't even say what arch is >> broken. >> > >> > Warner >> > >> > Warner >> > >> > On Dec 12, 2017 1:47 AM, "Antoine Brodin" wrote: >> > >> >> Author: antoine >> >> Date: Tue Dec 12 09:46:53 2017 >> >> New Revision: 326792 >> >> URL: https://svnweb.freebsd.org/changeset/base/326792 >> >> >> >> Log: >> >> Attempt to unbreak buildworld >> >> >> >> Modified: >> >> head/stand/uboot/common/main.c >> >> >> >> Modified: head/stand/uboot/common/main.c >> >> ============================================================ >> >> ================== >> >> --- head/stand/uboot/common/main.c Tue Dec 12 06:56:21 2017 >> >> (r326791) >> >> +++ head/stand/uboot/common/main.c Tue Dec 12 09:46:53 2017 >> >> (r326792) >> >> @@ -500,7 +500,7 @@ main(int argc, char **argv) >> >> archsw.arch_readin = uboot_readin; >> >> archsw.arch_autoload = uboot_autoload; >> >> >> >> - interact(NULL); /* doesn't return */ >> >> + interact(); /* doesn't return */ >> >> >> >> return (0); >> >> } >> >> >> >> >> _______________________________________________ >> svn-src-all@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-all >> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >> > > > > -- > Mateusz Guzik >