From owner-cvs-src@FreeBSD.ORG Thu Apr 26 08:30:06 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EED9F16A401; Thu, 26 Apr 2007 08:30:05 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id E22CC13C45D; Thu, 26 Apr 2007 08:30:03 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l3Q8U0ff075906; Thu, 26 Apr 2007 12:30:01 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l3Q8U0Gr075903; Thu, 26 Apr 2007 12:30:00 +0400 (MSD) (envelope-from yar) Date: Thu, 26 Apr 2007 12:29:59 +0400 From: Yar Tikhiy To: Scott Long Message-ID: <20070426082958.GC53614@comp.chem.msu.su> References: <200704211417.l3LEHUKK078832@repoman.freebsd.org> <462A27CD.5090006@freebsd.org> <1177170852.32761.0.camel@localhost> <20070424091858.GA31094@comp.chem.msu.su> <462FA0BC.8020207@freebsd.org> <20070426054228.GA53614@comp.chem.msu.su> <463049C6.9080100@samsco.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <463049C6.9080100@samsco.org> User-Agent: Mutt/1.5.9i Cc: src-committers@FreeBSD.org, Andre Oppermann , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Stephan Uphoff , Coleman Kane Subject: Re: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2007 08:30:06 -0000 On Thu, Apr 26, 2007 at 12:42:14AM -0600, Scott Long wrote: > Yar Tikhiy wrote: > >On Wed, Apr 25, 2007 at 02:41:00PM -0400, Stephan Uphoff wrote: > >>Yar Tikhiy wrote: > >>>On Sat, Apr 21, 2007 at 09:54:12AM -0600, Coleman Kane wrote: > >>> > >>>>On Sat, 2007-04-21 at 17:03 +0200, Andre Oppermann wrote: > >>>> > >>>>>Stephan Uphoff wrote: > >>>>> > >>>>>>ups 2007-04-21 14:17:30 UTC > >>>>>> > >>>>>> FreeBSD src repository > >>>>>> > >>>>>> Modified files: > >>>>>> sys/amd64/amd64 pmap.c > >>>>>> sys/i386/i386 pmap.c > >>>>>> Log: > >>>>>> Modify TLB invalidation handling. > >>>>>> > >>>>>> Reviewed by: alc@, peter@ > >>>>>> MFC after: 1 week > >>>>>> > >>>>>Could you be a bit more verbose what changed here and why it > >>>>>was done? > >>>>> > >>>>> > >>>>I agree. I would really like to know what the modification accomplishes. > >>>> > >>>Alas, we don't live in an ideal world. If we did, our commit > >>>messages would always follow the well-known guideline: > >>> > >>>0. Tell the essence of the change. > >>>1. Give the reason for the change. > >>>2. Explain the change unless it's trivial. > >>> > >>> > >>In the ideal world there are no NDAs :-) > > > >Was the change based on a document under NDA? Then this case raises > >an interesting question: to what extent an open source developer > >is allowed to explain his code that was based on a document under > >NDA? Of course, it should depend on the NDA, but I suspect that a > >typical NDA requires a lawyer to interpret it unambiguously (I've > >never signed one by myself), and an overcautious lawyer would say > >that the open source code itself violates the NDA because anybody > >can RTFS. :-) > > > > Wow, that was painful to read. NDAs that specifically allow source > code licensing and distribution are quite common. They even get written > and reviewed by lawyers! =-) It's a good news! But what about explaining the code to the public? - Mr. Developer, why does it take an ugly hack to make the device work? - Can't tell ya, I'm under NDA. ;-) -- Yar