From owner-freebsd-hackers@FreeBSD.ORG Fri Oct 25 01:11:25 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 2CD47113 for ; Fri, 25 Oct 2013 01:11:25 +0000 (UTC) (envelope-from sean_bruno@yahoo.com) Received: from nm11-vm3.bullet.mail.gq1.yahoo.com (nm11-vm3.bullet.mail.gq1.yahoo.com [98.136.218.158]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E35E82CCC for ; Fri, 25 Oct 2013 01:11:24 +0000 (UTC) Received: from [216.39.60.180] by nm11.bullet.mail.gq1.yahoo.com with NNFMP; 25 Oct 2013 01:11:18 -0000 Received: from [208.71.42.199] by tm16.bullet.mail.gq1.yahoo.com with NNFMP; 25 Oct 2013 01:11:18 -0000 Received: from [127.0.0.1] by smtp210.mail.gq1.yahoo.com with NNFMP; 25 Oct 2013 01:11:18 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1382663478; bh=VRC2K1BhShQN2KdwIHOW6MZVPdA4aCo2gqkr1vSK+tU=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Subject:From:Reply-To:To:In-Reply-To:References:Content-Type:Date:Message-ID:Mime-Version:X-Mailer; b=yqUxzPaO8VCY/NeFl0cQNqR41qpwlEc7onymfxafLGzBjmWW1/9JSwtLOTqsfQBRVNSXl1Jk4k0K3oc2QqyZYxVwl0SxkySXsSqjNzz/rdpVVoD9fcnf77JaZ3H33GnbWVFxgjgNt2bnuhgcRLpBnbFKJVvAeVuw1TT1azDw0iM= X-Yahoo-Newman-Id: 559524.65149.bm@smtp210.mail.gq1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: pq.97ekVM1l5IgmoBB0tgcNBSXcjaZIrzwSZHKtlkaLNJ3a XebrovPVAjHnLbCR5wOuc1SC_MxYylxvNNnsOGvmRdOWPIuDhLDTbxZ2PAN7 _U3N.rTBpOXiyIpGTEssUAPg2b1ql3lwQjbTnwr0oIxETq_2jXF5dQFQ5t5e Eev9edNqV4whsUsYFLThIY9W9gR7.ArydOEngIm4tjxpfAlIGvQ4BhCwbkuo yp1faJnNgziTLlpYUP0V5DAK3ZpGzq6Pd1SdA7nD5SMAvbjnG1EnOB_6CDOP 0PKsK0lJD7XCa1ZdlMm3oUOZCuvcGhgShKbyPwJ627d4OVmersmPKDbmo.nS At7GYoJT9VYDpEaKiHX7SMCGZjgDwMZXYg8tYva9R08ULqTOryhJtlFo.i1j 7GNXDuww6qwraMuleDRX7FZ8vuVfxX5PKfJ3tAEGId2Y3HVjxfCHAT3aYRmU Liym.OP1HPL._Lj.lWnBHyBY8i3W_Jqo.m22iB_gRYW07MlbTHRjFeQOjcdt cc_Wvd6Am.tj0dBpDRB8NT4aramAfrsebArECuPFT68xpF4H9A2avAHI6e4I J9Br1BM8UNdpYjvzjVd75GlMJKP_YFCyBxBLEsJem1h7.s.Rg X-Yahoo-SMTP: u5BKR6OswBC_iZJVfGRoMkTIpc8pEA4- X-Rocket-Received: from [192.168.100.5] (sean_bruno@63.138.121.126 with ) by smtp210.mail.gq1.yahoo.com with SMTP; 24 Oct 2013 18:11:18 -0700 PDT Subject: Re: gperf -- #define for if (0) ; else for From: Sean Bruno To: "freebsd-hackers@freebsd.org" In-Reply-To: <1382327705.2610.9.camel@localhost> References: <1382327705.2610.9.camel@localhost> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-AqiqxfkeUIz5FoIv9ZY0" Date: Thu, 24 Oct 2013 21:11:12 -0400 Message-ID: <1382663472.2498.2.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: sbruno@freebsd.org List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Oct 2013 01:11:25 -0000 --=-AqiqxfkeUIz5FoIv9ZY0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Sun, 2013-10-20 at 23:55 -0400, Sean Bruno wrote: > I don't even know why this is a thing in our code base. Its generating > a lot of clang noise due to -Wdangling-else >=20 > /usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/src/search.cc:417:15: > warning: add explicit braces to avoid dangling else [-Wdangling-else] > for (int i3 =3D imax; i3 >=3D 0; i3--) > ^ > /usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/src/search.cc:39:22: > note: expanded from macro 'for' > #define for if (0) ; else for > ^ >=20 > I see no reason to continue this and propose the removal of the line in > contrib/gperf/src/search.cc=20 >=20 > 37 > 38 /* Assume ISO C++ 'for' scoping rule. */ > 39 #define for if (0) ; else for >=20 >=20 Commented out at svn R257085 sean --=-AqiqxfkeUIz5FoIv9ZY0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iQEcBAABAgAGBQJSacUwAAoJEBkJRdwI6BaHHtsIAICBdJVQuWgFGoj7lT/dRSw9 KpVARzx6t14bOkE8jW0oUqmwC8qsvb3KBkRVqhvHYLwmP+2OmIulEbiLwkwKzw8W nGdXSv2Nz3IoZR1AxLCyo6dxvd2f0b+D5Mo0K3u7IuMSARuL444VN7HCoTj/Y+IO xPpV49aMM3O9LxuBqPwGVyQkGgzP43nskZRaQTHZVrODNBilhKQRhj72JdlLMF4J GJkHEC2BlDWqZq7a1r/jdVJ7QY94Cu2eoVIa9fEchyZhYYY8bFrNcK0vNCcL9EwM gZuTNQEq7s2AfTWUqliknIhhnfTxlAihFOLvVKLTAKNm04/P0qB/mZo4dZercoA= =cOef -----END PGP SIGNATURE----- --=-AqiqxfkeUIz5FoIv9ZY0--