From owner-freebsd-stable@FreeBSD.ORG Sat Oct 1 03:55:20 2005 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0C64C16A41F for ; Sat, 1 Oct 2005 03:55:20 +0000 (GMT) (envelope-from smartweb@leadhill.net) Received: from natco3.natcotech.com (natco3.natcotech.com [205.167.142.103]) by mx1.FreeBSD.org (Postfix) with ESMTP id 96F2543D49 for ; Sat, 1 Oct 2005 03:55:19 +0000 (GMT) (envelope-from smartweb@leadhill.net) Received: from ibm.nlcc.us (ldhl-ras1-dial-12-28-24-93.natcotech.com [12.28.24.93]) by natco3.natcotech.com (Postfix) with ESMTP id E0CDF62A53 for ; Fri, 30 Sep 2005 22:55:17 -0500 (CDT) Received: (qmail 8570 invoked by uid 89); 1 Oct 2005 03:55:17 -0000 Received: from unknown (HELO ?192.168.0.2?) (192.168.0.2) by ibm.nlcc.us with SMTP; 1 Oct 2005 03:55:17 -0000 Message-ID: <433E08A4.7070409@leadhill.net> Date: Fri, 30 Sep 2005 22:55:16 -0500 From: Billy Newsom User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Tim Howe , freebsd-stable@freebsd.org References: <87y85nuqhy.fsf@beaker.data-secure.net> <4335D1D2.9060501@leadhill.net> <87ll1jzqoa.fsf@beaker.data-secure.net> <87vf0noxgk.fsf_-_@beaker.data-secure.net> In-Reply-To: <87vf0noxgk.fsf_-_@beaker.data-secure.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Re: [PATCH] option to re-enable aggressive ATA probing X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Oct 2005 03:55:20 -0000 Tim Howe wrote: > Tim Howe writes: > > >>ata0-master: stat=0xd0 err=0xd0 lsb=0xd0 msb=0xd0 > > > This turned out to be the key. > > Version 1.51 of ata-lowlevel.c added a check for stat0/1, err, lsb, and I am just wondering about this. As far as I can tell, I have the ata-lowlevel.c file from March with this CVS tag (I run cvsup every other day, so this should be the latest for 5-Stable): src/sys/dev/ata/ata-lowlevel.c,v 1.44.2.5 2005/03/24 18:44:27 mdodd It is the 1.44.2.5 version, and I believe that I have been using it for awhile, eve before the sistuation showed up with my ATA drive not booting. As I reported bvefore, the July 4th cvs code worked for me, but not a recent one (late September). I would guess that something would have changed in that interim. You seem to be targeting either a different cvs version (intended for HEAD) or the problem you mention could have been broken over a period of time with help from other cvs changes? I don't know, but I will try the patch when I can. These are my relevent supfile config options: *default release=cvs tag=RELENG_5 *default delete use-rel-suffix src-all Billy > msb being identical. If they are, it aborts the probe. The attached > patch creates an option ATA_AGGRESSIVE_PROBE which disables this for the > old aggressive behavior (which may wait up to the full 31 seconds). > > I also took the liberty of reworking the still-busy check from 3 > equality tests to 2 bitmask tests. It seems simpler to my eye with > identical results, but if I missed something or the other style was > preferred please let me know. > > The patch is against 5-STABLE because that's what I have. > > >