From owner-svn-src-projects@freebsd.org Thu Aug 13 06:18:08 2015 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F40219A0546 for ; Thu, 13 Aug 2015 06:18:07 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x232.google.com (mail-wi0-x232.google.com [IPv6:2a00:1450:400c:c05::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9A70DC40; Thu, 13 Aug 2015 06:18:07 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wijp15 with SMTP id p15so244760547wij.0; Wed, 12 Aug 2015 23:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=+RrBqup4UR9EYJUL/fmcf3H1s5rIvYBPTU2Omt+lJzA=; b=M4emBohA17EFMaRBImda3Gm0O9HR/dETPZ244sAIixl7a+GyNqB2lF6+U4stiUE8U8 5Udgl6c2FqVIg6vPUq1bpFjA9mryHsS8ACNFD9Y2lq7Tnjcf5cVoAdXpFK2jvAdMOe5V 5Om9FBRcbjD41niP2Swy1/kLbE2/VRq2HYAbfPAuHTl+u0u+3kpzWJd1TwGoGIOmdYbL PBFO2BjKQd+YgWFo+ZpplaxF8AfwWi9weWVWa1Saj0FJUE6dSBt5KgV8LU7txjLP3rAl sJ0jZtqPsMoKTPV/FJb5/tfP9xRJEmYg/tsfCy5WU21UXplODS1NZeAZYU1WF+zeg2/g WweQ== X-Received: by 10.180.20.48 with SMTP id k16mr56024168wie.56.1439446685024; Wed, 12 Aug 2015 23:18:05 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id eb3sm1646483wib.24.2015.08.12.23.18.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Aug 2015 23:18:04 -0700 (PDT) Sender: Baptiste Daroussin Date: Thu, 13 Aug 2015 08:18:02 +0200 From: Baptiste Daroussin To: Bruce Evans Cc: Bruce Simpson , Davide Italiano , "src-committers@freebsd.org" , svn-src-projects@freebsd.org Subject: Re: svn commit: r286484 - projects/collation/usr.bin/localedef Message-ID: <20150813061802.GA62875@ivaldir.etoilebsd.net> References: <201508082257.t78MvIT1000841@repo.freebsd.org> <20150812182739.GB51754@ivaldir.etoilebsd.net> <55CB91FD.8000004@fastmail.net> <20150813114425.X996@besplex.bde.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="45Z9DzgjV8m4Oswq" Content-Disposition: inline In-Reply-To: <20150813114425.X996@besplex.bde.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2015 06:18:08 -0000 --45Z9DzgjV8m4Oswq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 13, 2015 at 12:16:41PM +1000, Bruce Evans wrote: > On Wed, 12 Aug 2015, Bruce Simpson wrote: >=20 > > On 12/08/15 19:27, Baptiste Daroussin wrote: > >> On Wed, Aug 12, 2015 at 01:22:17PM -0400, Davide Italiano wrote: > >>>> +#define RB_NUMNODES(type, name, head, cnt) do { \ > >>>> + type *t; \ > >>>> + cnt =3D 0; \ > >>>> + RB_FOREACH(t, name, head) { \ > >>>> + cnt++; \ > >>>> + } \ > >>>> +} while (0); > >>>> + > >>>=20 > >>> Can you commit this one to HEAD && move it to the right header? >=20 > This has too many bugs to commit. FYI the version proposed for tree(3): #define RB_COUNT(x, name, head, cnt) do { \ (cnt) =3D 0; \ RB_FOREACH((x), name, (head)) { \ (cnt)++; \ } \ } while (0) Bapt --45Z9DzgjV8m4Oswq Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlXMNpoACgkQ8kTtMUmk6Ewf5ACfZ3EGD8jQN678E5gWpn0kKnIr YYMAn3Nx8G6EKUn4txEk7r5OYp0xvABV =n4qP -----END PGP SIGNATURE----- --45Z9DzgjV8m4Oswq--