From owner-freebsd-current@freebsd.org Thu Aug 29 01:48:20 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F3676EC72C for ; Thu, 29 Aug 2019 01:48:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Jlr36tSdz41bP for ; Thu, 29 Aug 2019 01:48:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x832.google.com with SMTP id y26so1926645qto.4 for ; Wed, 28 Aug 2019 18:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ncujKWi8N4Bji8wzlfuAtDG1s7UzAwJNg4qA7irQXvw=; b=JTyX9la2O4EsMu3PKGp33zN569YE4l0MWNWsD1FU0xeeZej/paHQjprkUQjKX3L/tM efJntzMV9Fc0P9Z5htD1AGZOOB/XXpnp8yHx7KR8RiFWaVYq55zrMs4Fg+4oWviQqX+u KiT6POftJ/n/tZCrRqWJMpjvph2YwLelNmLksqb4AtAPV5TpvGaayVQde1rKxQqCXYYn l8Qdtx0ds/Gu0pHxocktEtz7+LTGp1FNvQ1kcgOjAd7xBYzXCGdeGm4XQMbphN1UTXjf i6RAS92kBOxds82b5Fb8tH2F3lSTklWsDN3Spi7Es7/yGXM4lHT2/xZBq5yAjU+yNKz4 M3ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ncujKWi8N4Bji8wzlfuAtDG1s7UzAwJNg4qA7irQXvw=; b=BjSpPOgxQ8qu+ZRBE+hA7PDOCnYf+yDqhy7cbnIWSf+0QR+8bq0Ov8ShAj1QqLCDJ4 Z0KGWJiabbEJNiP1iamWhpVT+QKGh51Il0ZHkWNZHLsxzXZJeJ9Edd4wmppDBLlvKi+O CbW4a2nXl8zrtT1Wnfo0WB/8RctJH9vko756g4zg1gEzQu8Zf068Iqnr/V0yeaeFRa6l Kp0hSdY/31ME8/HMTTvb061u37dXJbksPLVZgFqZq8dN9co5ErV8npyVySwYqJAr2Dhp KzCH54/RgmXcLTPxeyeGxkphIUKgi5n59mcc9aOZ3iQt6QvG3jLm4mFM9zenJ3yxAdqD /lZQ== X-Gm-Message-State: APjAAAXbF1TSB+x6WXQ5vHPy+0PJ+CAELlw8XE2Br2UTODYjVOmVZcKv opliNTLIBtX7867PYpHNf68H6+biOL+FuU7Ec2zDfQ== X-Google-Smtp-Source: APXvYqxPi7iq9Zla+edeeKIxv92y+wjBwefBa+d3Xi9nbREBKLxCMk3EAYzDgSxDGfc7IeTWwp/2+vJZJH8l1TOVFUE= X-Received: by 2002:aed:34a6:: with SMTP id x35mr7377982qtd.187.1567043298279; Wed, 28 Aug 2019 18:48:18 -0700 (PDT) MIME-Version: 1.0 References: <1115053193.64543.1567031661382.ref@mail.yahoo.com> <1115053193.64543.1567031661382@mail.yahoo.com> In-Reply-To: <1115053193.64543.1567031661382@mail.yahoo.com> From: Warner Losh Date: Wed, 28 Aug 2019 19:48:06 -0600 Message-ID: Subject: Re: Kernel-Crash when working with ubt0 To: mms.vanbreukelingen@gmail.com Cc: Maksim Yevmenkin , Konstantin Belousov , Hans Petter Selasky , "freebsd-current@freebsd.org" X-Rspamd-Queue-Id: 46Jlr36tSdz41bP X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=JTyX9la2; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::832) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-5.92 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-1.00)[-0.996,0]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.93)[ip: (-9.41), ipnet: 2607:f8b0::/32(-2.85), asn: 15169(-2.32), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_CC(0.00)[gmail.com] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Aug 2019 01:48:21 -0000 On Wed, Aug 28, 2019, 4:34 PM mms.vanbreukelingen@gmail.com < mms.vanbreukelingen@gmail.com> wrote: > @Maksim, I first did a "git apply -R bt.diff" and then > > root@freeBSD13:/usr/src # git apply --stat --check --ignore-whitespace > ng_btsocket_hci_raw.c.diff.txt > error: patch failed: > head/sys/netgraph/bluetooth/socket/ng_btsocket_hci_raw.c:1156 > error: head/sys/netgraph/bluetooth/socket/ng_btsocket_hci_raw.c: patch > does not apply > patch -p1 worked for me to apply it. And it worked just fine for everything once I rebooted. The patch looked fine to my eye. Warner Rebuilding with MTX_SPIN=y (withouth patch)... > On Wed, 28 Aug 2019 at 19:10, Maksim Yevmenkin > wrote: > > > > > Hmm... interesting.... > > > > > > > > I only took a brief look at it. I suppose I can ensure user space > address is wired and then copyout() can be called with mutex held > > > > > > >No, you cannot do this, at least without making the kernel to panic. > > > User might unmap the wired mapping at any time still. > > > > Kostik, > > > > i was thinking along the lines of vslock/vsunlock and copyout_nofault. > > basically similar to the sysctl code. do you think this would not > > work? > > actually, i dont think i need to hold lock over copyout. attached is > my version of the patch (untested) > > thanks, > max > >