From owner-freebsd-usb@FreeBSD.ORG Tue May 12 07:21:26 2009 Return-Path: Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6DA7F1065670; Tue, 12 May 2009 07:21:26 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe07.swip.net [212.247.154.193]) by mx1.freebsd.org (Postfix) with ESMTP id A58018FC15; Tue, 12 May 2009 07:21:25 +0000 (UTC) (envelope-from hselasky@c2i.net) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.0 c=1 a=jQPkJPAc13QA:10 a=omqvwZOFGbAA:10 a=MXw7gxVQKqGXY79tIT8aFQ==:17 a=Jq_JdvFlJ9SN9oML4-QA:9 a=_JEIg9WpBNmOKSU6jPEA:7 a=CP6f15A87BwnYehx-g4mKZaNyt0A:4 Received: from [62.113.132.61] (account mc467741@c2i.net HELO laptop) by mailfe07.swip.net (CommuniGate Pro SMTP 5.2.13) with ESMTPA id 1237775293; Tue, 12 May 2009 09:21:23 +0200 From: Hans Petter Selasky To: freebsd-usb@freebsd.org Date: Tue, 12 May 2009 09:23:56 +0200 User-Agent: KMail/1.9.7 References: <200905120040.n4C0eZdL003284@www.freebsd.org> In-Reply-To: <200905120040.n4C0eZdL003284@www.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200905120923.57886.hselasky@c2i.net> Cc: freebsd-gnats-submit@freebsd.org Subject: Re: usb/134476: [usb2] [umass] [quirk] Add quirk for Cypress xx6830xx X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2009 07:21:26 -0000 On Tuesday 12 May 2009, Lucius Windschuh wrote: > >Number: 134476 > >Category: usb > >Synopsis: [usb2] [umass] [quirk] Add quirk for Cypress xx6830xx > >Confidential: no > >Severity: non-critical > >Priority: low > >Responsible: freebsd-usb > >State: open > >Quarter: > >Keywords: > >Date-Required: > >Class: sw-bug > >Submitter-Id: current-users > >Arrival-Date: Tue May 12 00:50:01 UTC 2009 > >Closed-Date: > >Last-Modified: > >Originator: Lucius Windschuh > >Release: CURRENT@r191999 > >Organization: > >Environment: > > FreeBSD CURRENT 8.0-CURRENT FreeBSD 8.0-CURRENT #54 r191999M: Tue May 12 > 01:41:57 CEST 2009 root@current:/usr/obj/usr/src/sys/CURRENT i386 > > >Description: > > Attaching some external disk with a gjournaled UFS2 to my FreeBSD produces > these errors: umass1: Get Max Lun not supported (USB_ERR_STALLED) > [...] > (da1:umass-sim1:1:0:0): SYNCHRONIZE CACHE(10). CDB: 35 0 0 0 0 0 0 0 0 0 > (da1:umass-sim1:1:0:0): CAM Status: SCSI Status Error > (da1:umass-sim1:1:0:0): SCSI Status: Check Condition > (da1:umass-sim1:1:0:0): ILLEGAL REQUEST asc:20,0 > (da1:umass-sim1:1:0:0): Invalid command operation code > (da1:umass-sim1:1:0:0): Unretryable error > GEOM_JOURNAL: BIO_FLUSH not supported by da1s1e. > (da1:umass-sim1:1:0:0): SYNCHRONIZE CACHE(10). CDB: 35 0 0 0 0 0 0 0 0 0 > (da1:umass-sim1:1:0:0): CAM Status: SCSI Status Error > (da1:umass-sim1:1:0:0): SCSI Status: Check Condition > (da1:umass-sim1:1:0:0): ILLEGAL REQUEST asc:20,0 > (da1:umass-sim1:1:0:0): Invalid command operation code > (da1:umass-sim1:1:0:0): Unretryable error > GEOM_JOURNAL: BIO_FLUSH not supported by da1s1a. > > >How-To-Repeat: > > Put a gjournal on an external disk with a Cypress chipset and use it. > > >Fix: > > Attached patch. > > Patch attached with submission follows: > > Index: sys/dev/usb/storage/umass.c > =================================================================== > --- sys/dev/usb/storage/umass.c (Revision 191999) > +++ sys/dev/usb/storage/umass.c (Arbeitskopie) > @@ -427,6 +427,10 @@ > UMASS_PROTO_SCSI | UMASS_PROTO_BBB, > FORCE_SHORT_INQUIRY | NO_START_STOP | IGNORE_RESIDUE > }, > + {USB_VENDOR_CYPRESS, USB_PRODUCT_CYPRESS_XX6830XX, RID_WILDCARD, > + UMASS_PROTO_SCSI | UMASS_PROTO_BBB, > + NO_GETMAXLUN | NO_SYNCHRONIZE_CACHE > + }, If the descriptors are correct then use UMASS_PROTO_DEFAULT . Can you check this and I will import this patch. > {USB_VENDOR_DESKNOTE, USB_PRODUCT_DESKNOTE_UCR_61S2B, RID_WILDCARD, > UMASS_PROTO_SCSI | UMASS_PROTO_BBB, > NO_QUIRKS > Index: sys/dev/usb/usbdevs > =================================================================== > --- sys/dev/usb/usbdevs (Revision 191999) > +++ sys/dev/usb/usbdevs (Arbeitskopie) > @@ -1106,6 +1106,7 @@ > product CYPRESS FMRADIO 0x1002 FM Radio > product CYPRESS USBRS232 0x5500 USB-RS232 Interface > product CYPRESS SLIM_HUB 0x6560 Slim Hub > +product CYPRESS XX6830XX 0x6830 PATA Storage Device > > /* Daisy Technology products */ > product DAISY DMC 0x6901 USB MultiMedia Reader > > >Release-Note: > >Audit-Trail: > >Unformatted: --HPS