From nobody Mon Aug 12 13:02:07 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WjF685yWxz5SZN8 for ; Mon, 12 Aug 2024 13:02:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WjF681gB4z4Xcq for ; Mon, 12 Aug 2024 13:02:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1723467728; a=rsa-sha256; cv=none; b=lobT7g7iuQzfhg3Jvjp8R0SvIzmlwY2VaFtxyHOZH6zAtqmFNO9RzwkmdGsylL634G3Bul CO7DRCupSFFk69ywacmtxlaGRQao2QFeBv9KvgfpgKwPkNj900+CKMTIHSRGmmCpz5x1VR EPXcgA5PcLc9N2EtCbcqTwA5i10ndFc/zYxsuzrFDJYxF18g0lab+LyhYVoj4Y5X7FNobE 1LXsQIr1UDWUx64t9op2aObadSlDUCKiRJj7buGoizWq/b++xsDaTvhexvwxZ0pO21QTaN yv2xGlQF+Jzd+aAiQuKOu530k+4p2kBEwo365FIiR/QoyvRk89FnVKsSkR/YoQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723467728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JwS+ZE9KaawXWYATwMKbRLUPinCAtNjjmf9jKaALXA8=; b=brgTxcNj5zBFOlaNG3X1ByCMA2L6IkVM3s2AnGFlOxGLQPJ5p+JTW03YDx3A3QQ5S5gOeH nUCqTMlHVv3YZ6KV2uGO/hntQuZZG7erNYRQo0Ru/o46c61q9nWw+wOeSS5NT0SRAmkeR0 EhF5aG7Lxp/gE/mKC5J4ruBG0mQmCgbA4Ptbat3bvwsCngK4aS2N/HW0Y1Fyyy7B5CWg2p 7hQ5onBPTkuZcV2OqTWergpBnkJvWTtRR4YM6582cWFno/AsfqH5h8Uq5Dm376aAJof/zS q97cw65o78HfdCHWUEfdKKs0OIr7u97lbEKVScWVwMZ0PWST9PMZcqX8cfcq4w== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WjF6817fxzSKl for ; Mon, 12 Aug 2024 13:02:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 47CD28oF041015 for ; Mon, 12 Aug 2024 13:02:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 47CD28QQ041007 for bugs@FreeBSD.org; Mon, 12 Aug 2024 13:02:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 280770] mii_fdt_lookup_phy not checking common subnonode name Date: Mon, 12 Aug 2024 13:02:07 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.3-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: mibelanger@qnx.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280770 Bug ID: 280770 Summary: mii_fdt_lookup_phy not checking common subnonode name Product: Base System Version: 13.3-STABLE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: mibelanger@qnx.com The following is in mii_fdt_lookup_phy: /* * Now handle the "switch" case. * Search "ports" subnode for nodes that describe a switch port * including a PHY xref. * Since we have multiple candidates select one based on PHY addres= s. */ ports =3D ofw_bus_find_child(node, "ports"); if (ports <=3D 0) return (-1); The subnode name "ethernet-ports" is more commonly used. The code should a= dd an extra attempt with the "ethernet-ports" subnode name. e.g. /* * Now handle the "switch" case. * Search "ports" subnode for nodes that describe a switch port * including a PHY xref. * Since we have multiple candidates select one based on PHY addres= s. */ ports =3D ofw_bus_find_child(node, "ports"); if (ports <=3D 0) ports =3D ofw_bus_find_child(node, "ethernet-ports"); if (ports <=3D 0) return (-1); --=20 You are receiving this mail because: You are the assignee for the bug.=