From owner-dev-commits-src-branches@freebsd.org Tue Feb 2 16:57:43 2021 Return-Path: <owner-dev-commits-src-branches@freebsd.org> Delivered-To: dev-commits-src-branches@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9C23053743E; Tue, 2 Feb 2021 16:57:43 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DVWFz3vcyz3mqG; Tue, 2 Feb 2021 16:57:43 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm1-x330.google.com with SMTP id i9so2933616wmq.1; Tue, 02 Feb 2021 08:57:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ul7ClqMHgQAn/txdLP8TiV/T9fKC/+t+pP67I8pvcBY=; b=d3eSMT7WVmuajBG8aapozyPo2gLfu4zMXN/zsy21qJQMWFBtCJJu8bivDoRad9oMpH 6OtpBrLAZWUJxJT2Ie+BD2ZoOD3a3VMe475oOkFH1X5C6xK83zEUjPJ0fHSwONDp+ICy c28Up8dx2m8oj2DCsjmwuU/J1TvOEjGOSnxjYgFjzqWox/Q+lGd+lw+AIrFfYlHau+Rw ivYH/9tXJlM1ikcPEvwdEPoxpxGJWn+TcHzuJofTdX8VjO93XVe4508IZlrUUEsrh+fi 1HlF18tD6My/tf14Zg4c42RQ1NIfZdkviD7Lp/Y0ZXUp5EwHIVrr0/zvA1mD8T9ZifGi 39iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ul7ClqMHgQAn/txdLP8TiV/T9fKC/+t+pP67I8pvcBY=; b=KfABeL027ITRyoHOrD2EeFUq0ogTxAMfPp5lVSurvbWairk5pDRz4PUgyWkojXuD/F O7jhQIf/FAfpbh4TMqbSm7TVE86FUteqU4mMdLgFulhDEshZkr9lo3rdLeUFJDhhLrG2 GUh132BCsrOnqlY72dts65nIiFE4VLUqh9EVgoJvHG2SnDwltQLSzKAB+JkkRE+IEQ4d oUn258LmK6MTuekBRQUMH5XU784BeEkReezoMypkB3JfAPVwpnUVbIJzOJPEQA0+P27e OaK7pZqvMzf9u0gt29N1RQvcHzjSRygaooHfOBxlbpXZOv2vQGH0qA/9UlLQtQ7PRP5T n3zw== X-Gm-Message-State: AOAM531ShuyxLtRXpxl0vKnvdlomf+onOJoxD8FDEZt4M6sQTAQ7960H mlwUJZs4EfEc8W+UDmQlS6P5+t2dJs0Vx6a+DYDPjgi5PIw= X-Google-Smtp-Source: ABdhPJwUwvzs4wq8XHzPjEyPgSzI6AhFz+rRi2gGbQ0pOEbcvl6AYFSN1vjW9M01A8elKg37oVeycMFaM0M3xyGexJY= X-Received: by 2002:a1c:2ec2:: with SMTP id u185mr4478901wmu.83.1612285061614; Tue, 02 Feb 2021 08:57:41 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a5d:464c:0:0:0:0:0 with HTTP; Tue, 2 Feb 2021 08:57:40 -0800 (PST) In-Reply-To: <c8bd7ad4-0fa7-b75d-c2e2-84cd0930257b@FreeBSD.org> References: <202102011240.111CehGE094845@gitrepo.freebsd.org> <c8bd7ad4-0fa7-b75d-c2e2-84cd0930257b@FreeBSD.org> From: Mateusz Guzik <mjguzik@gmail.com> Date: Tue, 2 Feb 2021 17:57:40 +0100 Message-ID: <CAGudoHFWJ9RT3BKKC6_tQcFR8f4+0j2EdsZmuSBk2z9DrQPq+A@mail.gmail.com> Subject: Re: git: e92ab3adf4f9 - stable/13 - atomic: make atomic_store_ptr type-aware To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4DVWFz3vcyz3mqG X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-branches@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the stable branches of the FreeBSD src repository <dev-commits-src-branches.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-branches>, <mailto:dev-commits-src-branches-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-branches/> List-Post: <mailto:dev-commits-src-branches@freebsd.org> List-Help: <mailto:dev-commits-src-branches-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-branches>, <mailto:dev-commits-src-branches-request@freebsd.org?subject=subscribe> X-List-Received-Date: Tue, 02 Feb 2021 16:57:43 -0000 I thought I responded to this bit, I did not address the (in my opinion incorrect) claim that a fence can't be avoided rendering consume primitive pointless. I have a somewhat reply for this. but tl;dr yes, I'll add validation for pointer types A bug was reported in the namecache which I want to take care of before I do other stuff. On 2/2/21, John Baldwin <jhb@freebsd.org> wrote: > On 2/1/21 4:40 AM, Mateusz Guzik wrote: >> The branch stable/13 has been updated by mjg: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=e92ab3adf4f9848933439c9c2fca36df290c0884 >> >> commit e92ab3adf4f9848933439c9c2fca36df290c0884 >> Author: Mateusz Guzik <mjg@FreeBSD.org> >> AuthorDate: 2021-01-25 19:39:14 +0000 >> Commit: Mateusz Guzik <mjg@FreeBSD.org> >> CommitDate: 2021-02-01 12:39:16 +0000 >> >> atomic: make atomic_store_ptr type-aware >> >> (cherry picked from commit cc96f92a570e05636a20fdd15d4616b127bb9ecc) > > A couple of folks expressed concerns about this commit when it landed > in main due to it being too flexible (it allows you to store pointers > to non-pointer types, e.g.: > > char c; > uintptr_t p; > > atomic_store_ptr(&c, p); > > Silently becomes: > > atomic_store_char(&c, (char)p); > > Are you planning to address this? > > -- > John Baldwin > -- Mateusz Guzik <mjguzik gmail.com>