From owner-freebsd-hackers Fri May 26 1:42:17 2000 Delivered-To: freebsd-hackers@freebsd.org Received: from vexpert.dbai.tuwien.ac.at (vexpert.dbai.tuwien.ac.at [128.130.111.12]) by hub.freebsd.org (Postfix) with ESMTP id CF1A137B73B; Fri, 26 May 2000 01:42:11 -0700 (PDT) (envelope-from pfeifer@dbai.tuwien.ac.at) Received: from [128.130.111.10] (nunki [128.130.111.10]) by vexpert.dbai.tuwien.ac.at (8.9.3/8.9.3) with ESMTP id KAA16707; Fri, 26 May 2000 10:42:08 +0200 (MET DST) Date: Fri, 26 May 2000 10:42:07 +0200 (MET DST) From: Gerald Pfeifer To: freebsd-hackers@freebsd.org, ache@freebsd.org, peter@freebsd.org Cc: Wei Dai Subject: ncurses.h and #define trace _nc_trace Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG The following change to /usr/include/ncurses.h which adds a #define trace _nc_trace causes problems with our Wine port and probably further software: 1.1.1.3 (vendor branch) Wed May 24 10:44:45 2000 UTC by peter CVS Tags: v5_0_19991023, HEAD; Branch: NCURSES Bring in the fix for the trace/_nc_trace issue, without breaking the vendor branching. The author has fixed this also so we can do this safely. 1.1.1.2.2.1 Tue May 23 13:42:17 2000 UTC by ache Branch: RELENG_4 MFC: trace -> _nc_trace For example, consider the following snippet: void _nc_trace() { } #define trace _nc_trace main() { long trace=0; if( &trace != &_nc_trace ) printf("Okay\n"); } As another example, consider Wine, where this change causes: ../libwine.so: undefined reference to `__GET_DEBUGGING__nc_trace' due to a new interaction with the TRACE macro in debugtools.h. http://cvs.winehq.com/cvsweb/wine/include/debugtools.h?rev=1.9 has the source of that Wine include file. In my opinion, we either have to show that the code in Wine is in violation of ANSI/ISO C, or find a way to fix ncurses. How about adding a stub instead of a #define? Performance really shouldn't be an issue in this case! Gerald -- Gerald "Jerry" pfeifer@dbai.tuwien.ac.at http://www.dbai.tuwien.ac.at/~pfeifer/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message