From owner-freebsd-audit  Wed Mar 20 12:37:13 2002
Delivered-To: freebsd-audit@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 39AFF37B400; Wed, 20 Mar 2002 12:36:32 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id HAA08605;
	Thu, 21 Mar 2002 07:36:29 +1100
Date: Thu, 21 Mar 2002 07:36:40 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@gamplex.bde.org>
To: <markm@FreeBSD.ORG>
Cc: <audit@FreeBSD.ORG>
Subject: Re: Make find(1) standalone - commit candidate
In-Reply-To: <200203201335.g2KDZL4j025080@grimreaper.grondar.org>
Message-ID: <20020321072334.Q11390-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

On Wed, 20 Mar 2002 markm@FreeBSD.ORG wrote:

OK, except there are now (surprisingly, only) 3 clones of getdate.y
(the others are in tar and cvs), and the yacc stuff in the Makefile
is as bogus as before.

> Index: Makefile
> ===================================================================
> RCS file: /home/ncvs/src/usr.bin/find/Makefile,v
> retrieving revision 1.12
> diff -u -d -r1.12 Makefile
> --- Makefile	27 Feb 2002 17:57:00 -0000	1.12
> +++ Makefile	20 Mar 2002 09:36:58 -0000
> @@ -2,9 +2,7 @@
>  # $FreeBSD: src/usr.bin/find/Makefile,v 1.12 2002/02/27 17:57:00 dwmalone Exp $
>
>  PROG=	find
> -SRCS=	find.c function.c ls.c main.c misc.c operator.c option.c getdate.y
> -CLEANFILES+= getdate.c y.tab.h
> -CFLAGS+= -I${.CURDIR}/../../gnu/usr.bin/cvs/lib -DHAVE_CONFIG_H
> -.PATH:	${.CURDIR}/../../contrib/cvs/lib
> +SRCS=	find.c function.c ls.c main.c misc.c operator.c option.c parsedate.y
> +CLEANFILES+= parsedate.c y.tab.h
>
>  .include <bsd.prog.mk>

The CLEANFILES lines have many style bugs:
- use of "+=" for the first initialization of a variable.
- duplicate getdate.c/parsedate.c.  It is added automatically by bsd.prog.mk.
- bogus y.tab.h.  y.tab.h is not created, since it is not in SRCS.  getdate.h
  is created instead (and automatically put in CLEANFILES).

The (missing) YFLAGS line has a style bug.  The default YFLAGS is -d.  This
causes getdate.h to be created and removed, but getdate.h is not used.
YFLAGS should be set to <nothing> to prevent this garbage.

See tar/Makefile and cvs/lib/Makefile for correct handling of getdate.y.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message