Date: Sun, 6 May 2018 09:45:34 -0600 From: Adam Weinberger <adamw@adamw.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: Alexey Dokuchaev <danfe@FreeBSD.org>, Koichiro Iwao <meta@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r469188 - head/ports-mgmt/pkg_replace Message-ID: <612D8486-6A77-4CBD-8276-AFE53DF2AC92@adamw.org> In-Reply-To: <20180506150441.52w3lodurubkz2lb@ivaldir.net> References: <201805061015.w46AF3HQ070595@repo.freebsd.org> <20180506102749.GA58637@FreeBSD.org> <CC3C2D9C-F9B7-48DE-A53B-D9193C6CE65E@adamw.org> <20180506150441.52w3lodurubkz2lb@ivaldir.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 6 May, 2018, at 09:04, Baptiste Daroussin <bapt@FreeBSD.org> wrote: > > On Sun, May 06, 2018 at 08:41:36AM -0600, Adam Weinberger wrote: >>> On 6 May, 2018, at 04:27, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: >>> >>> On Sun, May 06, 2018 at 10:15:03AM +0000, Koichiro Iwao wrote: >>>> New Revision: 469188 >>>> URL: https://svnweb.freebsd.org/changeset/ports/469188 >>>> >>>> Log: >>>> ports-mgmt/pkg_replace: Update to 20180424 >>>> >>>> - Cleanup code >>>> - Speed up and strictly check package's dependencies >>>> - While here, pet portlint by using pkg-plist instead of PLIST_FILES >>> >>> Could you explain what did you achieve by moving three-line PLIST_FILES >>> into pkg-plist? How can "pet portlint" be a reason for a change while >>> we generally encourage converting <6-line pkg-plist's into PLIST_FILES? >>> >>> ./danfe >>> >>>> - >>>> -PLIST_FILES= sbin/pkg_replace \ >>>> - man/man1/pkg_replace.1.gz \ >>>> - "@sample %%ETCDIR%%/pkg_replace.conf.sample" >>> >>> Correct PLIST_FILES should read: >>> >>> PLIST_FILES= sbin/pkg_replace \ >>> man/man1/pkg_replace.1.gz \ >>> @sample\ etc/pkg_replace/pkg_replace.conf.sample >>> >>> ./danfe >> >> Sorry, Alexey, but portlint was right here. @sample and other macros >> should >> *never* appear in PLIST_FILES. Even if the port installs only a single >> file, >> if it’s a @sample, it goes in pkg-plist. > Same why :) > > Alexey is wrong imho about the '\' the quotes where fine, but he is right > about > the replacement of the %%ETCDIR%%. > > I don't understand why keywords should be forbiddent in PLIST_FILES macros? > > The framework itself uses macros in PLIST_FILES Oh, my. I thought this was a thing! I was so certain that this was (at least at one time) policy. Did this change, or did I just invent the whole thing? # Adam — Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?612D8486-6A77-4CBD-8276-AFE53DF2AC92>