From owner-freebsd-current@FreeBSD.ORG Wed Aug 23 11:11:17 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B477D16A4DD for ; Wed, 23 Aug 2006 11:11:17 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from py-out-1112.google.com (py-out-1112.google.com [64.233.166.180]) by mx1.FreeBSD.org (Postfix) with ESMTP id EB16B43D66 for ; Wed, 23 Aug 2006 11:11:08 +0000 (GMT) (envelope-from pyunyh@gmail.com) Received: by py-out-1112.google.com with SMTP id o67so148383pye for ; Wed, 23 Aug 2006 04:11:08 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=Yzz1LFZ9g9K/Y9PD/4Wkg6lMPjx34/XRY45+A6M00qamYy3U3E1av4ExgAg4uI4+A1LFZqqoCk2F60n3e0r/ZhF+5fd0UEr1q3A/yLC8umb0FRwAPq8AntdqyyaXq3zvKdudvSw8s7xZGW2Tb8JBQ/9R4isNxDKWNISXDCNFG6Y= Received: by 10.35.38.17 with SMTP id q17mr383949pyj; Wed, 23 Aug 2006 04:11:08 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.gmail.com with ESMTP id 15sm41926nzp.2006.08.23.04.11.06; Wed, 23 Aug 2006 04:11:08 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id k7NBB8eD020255 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 Aug 2006 20:11:08 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id k7NBB8kw020254; Wed, 23 Aug 2006 20:11:08 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Wed, 23 Aug 2006 20:11:08 +0900 From: Pyun YongHyeon To: Gleb Smirnoff Message-ID: <20060823111108.GK17902@cdnetworks.co.kr> References: <20060822042023.GC12848@cdnetworks.co.kr> <20060823093741.GF96644@FreeBSD.org> <20060823095504.GI17902@cdnetworks.co.kr> <20060823100420.GG96644@cell.sick.ru> <20060823105118.GJ17902@cdnetworks.co.kr> <20060823110619.GL96644@cell.sick.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060823110619.GL96644@cell.sick.ru> User-Agent: Mutt/1.4.2.1i Cc: freebsd-current@FreeBSD.org Subject: Re: call for bge(4) testers X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Aug 2006 11:11:17 -0000 On Wed, Aug 23, 2006 at 03:06:19PM +0400, Gleb Smirnoff wrote: > On Wed, Aug 23, 2006 at 07:51:18PM +0900, Pyun YongHyeon wrote: > P> > P> Its sole purpose is to reinitialize hardware for real watchdog > P> > P> timeouts. It's not fix for general watchdog timeouts. As I said other > P> > P> mails, the fake watchdog timeout(losing Tx interrupts) for hardwares > P> > P> with Tx interrupt moderation capability could be normal thing. So I > P> > P> just want to know bge(4) also has the same feature(bug). > P> > > P> > According to several emails about em(4) fake watchdog timeouts, the > P> > problem can be fixed by setting debug.mpsafenet=0. This makes me think > P> > that the problem isn't caused by TX interrupt moderation, but some race > P> > in the kernel. Really, if_slowtimo() doesn't acquire driver lock before > P> > checking and modifying the if_timer field. > P> > > P> > P> Hmm... I didn't say the problem was caused by TX interrupt moderation. > P> I can't sure but I'm under the impression it has *two* different issues. > P> If you think fake watchdog timeout fix is not adequate one please > P> let me know. I'll backout the change if you want. > > I don't think you should backout it until we find a solution. > However, I'd ask you don't MFC it. > ok. Lets find out real cause of bug. > P> > Afaik, NIC drivers that can do interrupt moderation should set a timer > P> > to a sane value, based on interrupt moderation settings, so that the > P> > watchdog won't be ever called fakely. > P> > P> Yes. Normally it should. But I saw the issues on Marvell Yukon too. > > Does Marvell Yukon have interrupt moderation? > Yes. Check archives for sk(4) watchdog. -- Regards, Pyun YongHyeon