From owner-cvs-all Mon May 13 4:55:18 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.pcnet.com (pcnet1.pcnet.com [204.213.232.3]) by hub.freebsd.org (Postfix) with ESMTP id C8E7337B407; Mon, 13 May 2002 04:55:06 -0700 (PDT) Received: from vigrid.com (pm3-pt74.pcnet.net [206.105.29.148]) by mail.pcnet.com (8.12.3/8.12.1) with ESMTP id g4DBt018016051; Mon, 13 May 2002 07:55:00 -0400 (EDT) Message-ID: <3CDF9CDB.BF0E65F5@vigrid.com> Date: Mon, 13 May 2002 07:00:43 -0400 From: Dan Eischen X-Mailer: Mozilla 4.74 [en] (X11; U; FreeBSD 5.0-CURRENT i386) X-Accept-Language: en MIME-Version: 1.0 To: Alfred Perlstein Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc_r/uthread pthread_private.h uthread_attr_setguardsize.cuthread_init.c uthread_stack.c References: <200205130758.g4D7wFo67279@freefall.freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Alfred Perlstein wrote: > > alfred 2002/05/13 00:58:15 PDT > > Modified files: > lib/libc_r/uthread pthread_private.h > uthread_attr_setguardsize.c > uthread_init.c uthread_stack.c > Log: > Don't use PAGE_SIZE in userland, instead use getpagesize(), this is to > allow running on other arches when the instructions are supported but > the page size granularity is not. This adds namespace pollution to libc_r. Please fix and precede externals with underscores. You should be able to do 'nm libc_r.so.5 | grep " T "' and not see anything that isn't preceded with underscores. -- Dan Eischen To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message