From owner-freebsd-fs@freebsd.org Sat Feb 20 01:58:24 2016 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E5D0CAAEE72 for ; Sat, 20 Feb 2016 01:58:23 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-annu.net.uoguelph.ca (esa-annu.mail.uoguelph.ca [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id 963021DAA; Sat, 20 Feb 2016 01:58:23 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) IronPort-PHdr: 9a23:W/AzbB3QGM83i0t/smDT+DRfVm0co7zxezQtwd8ZsegVLvad9pjvdHbS+e9qxAeQG96LtLQZ0qGN7OjJYi8p39WoiDg6aptCVhsI2409vjcLJ4q7M3D9N+PgdCcgHc5PBxdP9nC/NlVJSo6lPwWB6kO74TNaIBjjLw09fr2zQd6NyZnunLvts7ToICx2xxOFKYtoKxu3qQiD/uI3uqBFbpgL9x3Sv3FTcP5Xz247bXianhL7+9vitMU7q3cY6Lod8JtEXLvSUb41QJZjIHIhKW9mytfssEz5TACMrl4VWWYSnx8AVxLA5Rr5Wpr0mjb9ufdw3DGae8b/G+NnEQ++5rtmHUe7wBwMMCQ0pTna X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2CtBACrx8dW/61jaINehAxtBrpMgWgXCoUiSgKBehMBAQEBAQEBAWMngi2CFAEBAQMBAQEBICsgCwULAgEIGAICDRkCAicBCSYCDAcEARwEh3EIDq0KjmQBAQEBAQUBAQEBAQEBFQR7hReBdYJGhBYBAQVkgjSBOgWOHohphVeFIJFajkYCIQFAggIagWYeLgeHQjR9AQEB X-IronPort-AV: E=Sophos;i="5.22,473,1449550800"; d="scan'208";a="268704028" Received: from nipigon.cs.uoguelph.ca (HELO zcs1.mail.uoguelph.ca) ([131.104.99.173]) by esa-annu.net.uoguelph.ca with ESMTP; 19 Feb 2016 20:58:22 -0500 Received: from localhost (localhost [127.0.0.1]) by zcs1.mail.uoguelph.ca (Postfix) with ESMTP id 6D46A15F5AD; Fri, 19 Feb 2016 20:58:22 -0500 (EST) Received: from zcs1.mail.uoguelph.ca ([127.0.0.1]) by localhost (zcs1.mail.uoguelph.ca [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id TpMzLxHRadOD; Fri, 19 Feb 2016 20:58:21 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by zcs1.mail.uoguelph.ca (Postfix) with ESMTP id AD9BE15F5B2; Fri, 19 Feb 2016 20:58:21 -0500 (EST) X-Virus-Scanned: amavisd-new at zcs1.mail.uoguelph.ca Received: from zcs1.mail.uoguelph.ca ([127.0.0.1]) by localhost (zcs1.mail.uoguelph.ca [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id IVs8Em9s68UE; Fri, 19 Feb 2016 20:58:21 -0500 (EST) Received: from zcs1.mail.uoguelph.ca (zcs1.mail.uoguelph.ca [172.17.95.18]) by zcs1.mail.uoguelph.ca (Postfix) with ESMTP id 7337015F5AD; Fri, 19 Feb 2016 20:58:21 -0500 (EST) Date: Fri, 19 Feb 2016 20:58:21 -0500 (EST) From: Rick Macklem To: lev@FreeBSD.org Cc: freebsd-fs@freebsd.org Message-ID: <571539848.4340752.1455933501390.JavaMail.zimbra@uoguelph.ca> In-Reply-To: <56C752CD.4090203@FreeBSD.org> References: <56C752CD.4090203@FreeBSD.org> Subject: Re: Panic in NFS client on CURRENT MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [172.17.95.12] X-Mailer: Zimbra 8.0.9_GA_6191 (ZimbraWebClient - FF44 (Win)/8.0.9_GA_6191) Thread-Topic: Panic in NFS client on CURRENT Thread-Index: EtQjrJrUaWkim3H1cvthW9NvQL526w== X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Feb 2016 01:58:24 -0000 Lev wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > > I've hit panic in NFSv4 client on fresh CURRENT, which looks like bug > 206634. > I took a look and this appears to have been introduced by r285632, which changed vfs_hash_get() to no longer VI_LOCK() the vnode. I'm not sure, but I think you can just delete/comment out the test for the VI_INTERLOCK and subsequent panic. (line#3371,3372 in sys/fs/nfsclient/nfs_clvnops.c in head). It should only happen when the server goes into state recovery mode after a server reboot or network partitioning from clients. (As I mentioned in PR#206634, these recoveries should be avoided whenever possible. If a scheduled restart of an NFSv4 server is done, all clients should be unmounted before the reboot, if at all practical.) However, I think the panic() is now just bogus and should be removed. rick > I have core saved and could provide additional information. > > - -- > // Lev Serebryakov > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQJ8BAEBCgBmBQJWx1LNXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w > ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRGOTZEMUNBMEI1RjQzMThCNjc0QjMzMEFF > QUIwM0M1OEJGREM0NzhGAAoJEOqwPFi/3EeP5RQP+gIqYjxZKpUk+sxAoE1Tds1K > BOkBPeFPj38FuaWUFN3LmM2HH3DZpjjScHa3WUeNov7KNduBTnBB0QJbYUOmXThg > 9ggOExQR+Cjci1YmBBa/8m8Naeik0wza0XmdbUlzx/qMyfpEMPmITZqq9X+/dcbb > 7xxpwUTveR3mZc9z7yS6qFDN+oqUMILFF08jq3B+715My0f2urBSBNqP4CJ5lc/a > sTNo2jTZG9PWug7blVIX03cX/hwVz9Wa3io+p5XNF+8ZGq2b+86sSPYf/6FjPWh3 > g/pMfX+cVYiOVsyWewASnRKse4S2my5gZ4OTbtrnMjOhFPhDbacM65XBdKSBIQDK > IXEsod+YvyMB+cBjvReyErLV0KoYkY/u5TzfaVuSAvKZ+MwuFSo57m6u2XSG/Z5f > XBvcTElIvFf78ZAmqJ5heyJSgONUKEUDo17w74Um6l3d0gP2QZDVrx5QF6hLb7Tx > ssepvE9DIEOijImBkn78QbxRaJzqXLYckxp1LPM0XtspbjoZImfLrCm8jE3RQJFs > cIcNCE9iWR0DD1fgSl7C/eifljfkSxF8hKf601ZYtweXZ89OWCh/HP3O8TfS0Fj/ > 9vOHdtC/AtCMQVHU1kdRyvjRCrpjVQV5WweCf1q641DSXuHkSIhWz2rfueX4I187 > BUokRbH5pntYoubADtmN > =y6WT > -----END PGP SIGNATURE----- > _______________________________________________ > freebsd-fs@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" >