Date: Sun, 29 May 2022 06:54:56 -0700 From: Christopher Bowman <crb@chrisbowman.com> To: freebsd-hackers@freebsd.org Subject: putchar in boot1.c adds extra blank lines on Xilinx ZYNQ board with U-boot 2020.04 Message-ID: <3D090089-F20B-4B5D-A589-391E6536A875@chrisbowman.com>
next in thread | raw e-mail | index | archive | help
Looking at /usr/src/stand/efi/boot1/boot1.c
The bottom of the file has:
void
putchar(int c)
{
CHAR16 buf[2];
if (c =3D=3D '\n') {
buf[0] =3D '\r';
buf[1] =3D 0;
ST->ConOut->OutputString(ST->ConOut, buf);
}
buf[0] =3D c;
buf[1] =3D 0;
ST->ConOut->OutputString(ST->ConOut, buf);
}
On my platform this results in an extra blank line after each new line.
I=E2=80=99m running on a Xilinx ZYNQ board with U-boot 2020.04.
Does this blank line show on other platforms too? If so is this the =
desired functionality? Perhaps it=E2=80=99s needed for serial consoles =
to work right?
I=E2=80=99m running locally with the if statement completely removed and =
that fixes the extraneous blank lines I see.
Regards,
Christopher=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3D090089-F20B-4B5D-A589-391E6536A875>