Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 14 Apr 2017 18:54:35 -0700
From:      Mark Millard <markmi@dsl-only.net>
To:        Alexander Kabaev <kabaev@gmail.com>, FreeBSD Ports <freebsd-ports@freebsd.org>
Subject:   Re: lang/gcc6-aux for head beyond __nonnull related issues: vm_ooffset_t and vm_pindex_t related changes (and more)
Message-ID:  <86A361FC-8C3A-48A0-9C5D-7C1DA166D176@dsl-only.net>

next in thread | raw e-mail | index | archive | help
Alexander Kabaev kabaev at gmail.com on Sat Apr 15 00:20:40 UTC 2017
wrote:
. . .

> it was suggested multiple times that the whole fixinc step is
> ultimately harmful and serves no useful purpose and probably should be
> disabled in built packages outright. Is there a reason not to do it?
> Even Redhat appears to do the slimming in their rpms:
> 
> mv $FULLPATH/include-fixed/syslimits.h $FULLPATH/include/syslimits.h
> mv $FULLPATH/include-fixed/limits.h $FULLPATH/include/limits.h
> for h in `find $FULLPATH/include -name \*.h`; do
>   if grep -q 'It has been auto-edited by fixincludes from' $h; then
>     rh=`grep -A2 'It has been auto-edited by fixincludes from' $h |
> tail -1 | sed 's|^.*"\(.*\)".*$|\1|'` diff -up $rh $h || :
>     rm -f $h
>   fi
> done

I'll note that:

http://www.linuxfromscratch.org/lfs/view/7.1/chapter06/gcc.html

reports as one of its steps (quote):

The fixincludes script is known to occasionally erroneously attempt
to "fix" the system headers installed so far. As the headers up to
this point are known to not require fixing, issue the following
command to prevent the fixincludes script from running:

sed -i 's@\./fixinc\.sh@-c true@' gcc/Makefile.in

(End quote)

So seems that disabling fixinc.sh's use is fairly common when
the headers are known to "not require fixing" (i.e., are known
to already be gcc compliant).




===
Mark Millard
markmi at dsl-only.net




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86A361FC-8C3A-48A0-9C5D-7C1DA166D176>