From owner-freebsd-hackers@freebsd.org Tue Jun 12 18:05:49 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ADBF6100E25A for ; Tue, 12 Jun 2018 18:05:49 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pg0-x232.google.com (mail-pg0-x232.google.com [IPv6:2607:f8b0:400e:c05::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 30A6472410 for ; Tue, 12 Jun 2018 18:05:49 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pg0-x232.google.com with SMTP id 15-v6so11833694pge.2 for ; Tue, 12 Jun 2018 11:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=AQYw2MEWsven4xJ0HSK5q6Gl6xPdAJo69sS/svQkLOA=; b=Cawq43OGjtD2VCb+ZN5QL7YWU4TPD1VuB9KOHmVk16YJcgw0oZ9HFpyCfNk4C2aiKq rQx/F/1cS8HcCEONa3wco4Zd9lybdryvuheEf7M0M1toxLvCztIOX+s2CpngESRJtyVr BQl+GsyHBoA7CPuAbSrC5ov2L53sFNgsABJZ9uHA20OFUGb5+7DmpS7hJqzM3AMyEUb8 HkmVIugYbzO8xvZPmPU7U9oEWZgca39cHWszhZv2Sl7Nb+nHhzSN/JXj5dT6piiuMwSP a6aW8tL+98rcVaJnfoZ1OTPmihdbHMGHGXzrff6TPD/bGhgwQ3ThXlc2ROa1mHYBnEt6 lYfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=AQYw2MEWsven4xJ0HSK5q6Gl6xPdAJo69sS/svQkLOA=; b=Sl20s5LmS9E8maPCtYXmEP/GpfaOAdb5UyMHDVEq/gYiOk7rnvDKVYo+wN2+GDMT6+ /zGmQpsAta1TQrwUkHQt5KRiuDha+OnvVmD5fSYqIHzOWVmB8KMCN51Zvk3BJpPYnas+ DQdaznXm70ARRQOZTQwoTxI+HQdgNn+UNqlujgce92hxZxPH4/BsgMVhnnD5VhFH/yTr hJ0BSlE+THjhqXFjVEQJZElOAPGppukXjnhDVtq1XBMmfu2Sz8IHeVfTEIIAsZ7Nfcpv rjWIoUL7uGAgmeeeZZdnH9q2UN3Sexh331EIiA5776zi39RVWCZnLSJehgSz/iWwQpBf qJkA== X-Gm-Message-State: APt69E0snReMzrqjleIDTcwG27f0mAchnESNnpBd8rmFKAu89U4rZ/ZG wAE96WfC0obEViBRISlViCc= X-Google-Smtp-Source: ADUXVKK6/N8yRibpKlU1+nw5YRXE9IxETMCQdbQNDAsSfccT4GdyhXBAdzbVqQi09EptSihonhAv9A== X-Received: by 2002:a62:8202:: with SMTP id w2-v6mr1519917pfd.32.1528826748183; Tue, 12 Jun 2018 11:05:48 -0700 (PDT) Received: from raichu (toroon0560w-lp140-02-70-49-169-156.dsl.bell.ca. [70.49.169.156]) by smtp.gmail.com with ESMTPSA id 14-v6sm760840pgc.63.2018.06.12.11.05.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Jun 2018 11:05:47 -0700 (PDT) Sender: Mark Johnston Date: Tue, 12 Jun 2018 14:05:44 -0400 From: Mark Johnston To: Warner Losh Cc: "freebsd-hackers@freebsd.org" Subject: Re: specifying alignment of loader files Message-ID: <20180612180544.GG56138@raichu> References: <20180612170420.GD56138@raichu> <20180612171649.GE56138@raichu> <20180612175130.GF56138@raichu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2018 18:05:50 -0000 On Tue, Jun 12, 2018 at 11:55:27AM -0600, Warner Losh wrote: > On Tue, Jun 12, 2018 at 11:51 AM, Mark Johnston wrote: > > > On Tue, Jun 12, 2018 at 11:45:01AM -0600, Warner Losh wrote: > > > On Tue, Jun 12, 2018 at 11:16 AM, Mark Johnston > > wrote: > > > > > > > On Tue, Jun 12, 2018 at 11:11:25AM -0600, Warner Losh wrote: > > > > > On Tue, Jun 12, 2018 at 11:04 AM, Mark Johnston > > > > wrote: > > > > > > > > > > > Hi, > > > > > > > > > > > > I'm writing some code which processes a file loaded by the > > loader. I > > > > > > want the file's contents to be available at a certain alignment in > > > > > > memory, and as far as I can see, the loader provides no alignment > > > > > > guarantees today. The access will happen early enough during boot > > that > > > > > > making an aligned copy of the data will be awkward, so I'd like the > > > > > > loader to provide the desired alignment. > > > > > > > > > > > > I'm considering adding a new "module_align" variable that would > > specify > > > > > > the alignment for a given file type, and plumb that through to > > > > > > command_load(). Does anyone have an alternate suggestion, or an > > > > > > objection to my proposal? > > > > > > > > > > > > > > > > I thought the loader already did that for ELF sections... Why not > > wrap > > > > your > > > > > file in such a segment? > > > > > > > > In this case it's a raw binary file (CPU microcode), and I want to be > > > > able to load it without any modifications or wrappers. > > > > > > > > > > How do you identify the type then? I'm ok in theory with this (though a > > > variable is more flexible than needed), but that's my main concern. > > What's > > > the alignment required btw? > > > > It'd be a property of the type, e.g., > > > > cpu_ucode_name=/boot/firmware/... > > cpu_ucode_align=16 > > > > I do feel like having a separate variable is overkill, but I can't see > > a less invasive solution that isn't hacky. > > > > The required alignment for Intel is 16 bytes; I'm not yet sure whether > > AMD has a required alignment. > > > > OK. That seems sane. I was thinking it was more general than this, but I'm > cool with what you've outlined. > > OTOH, wouldn't just loading all files on page boundaries suffice? It would (and that's actually what I did in my test branch). We already have to do this for ELF, and the only other frequently loaded file I can think of is /boot/entropy. Can you think of any scenarios where forcing page alignment for all files would waste a substantial amount of memory? If not, I might just go ahead with that approach for now and wait for a good reason before introducing customizable alignments.