From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Oct 25 12:50:19 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8079B16A4CE for ; Mon, 25 Oct 2004 12:50:19 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6452043D2D for ; Mon, 25 Oct 2004 12:50:19 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i9PCoJ6P093928 for ; Mon, 25 Oct 2004 12:50:19 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i9PCoJx9093927; Mon, 25 Oct 2004 12:50:19 GMT (envelope-from gnats) Resent-Date: Mon, 25 Oct 2004 12:50:19 GMT Resent-Message-Id: <200410251250.i9PCoJx9093927@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dag-Erling Smørgrav Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1B16A16A4CE for ; Mon, 25 Oct 2004 12:42:21 +0000 (GMT) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 710F343D41 for ; Mon, 25 Oct 2004 12:42:20 +0000 (GMT) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id 4D9DD5314; Mon, 25 Oct 2004 14:42:19 +0200 (CEST) Received: from dwp.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id 93E0D5310 for ; Mon, 25 Oct 2004 14:42:11 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 2602) id 70F0FB85E; Mon, 25 Oct 2004 14:42:11 +0200 (CEST) Message-Id: <20041025124211.70F0FB85E@dwp.des.no> Date: Mon, 25 Oct 2004 14:42:11 +0200 (CEST) From: Dag-Erling Smørgrav To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/73116: [PATCH] bug in PHP dependency checks X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Dag-Erling Smørgrav List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Oct 2004 12:50:19 -0000 >Number: 73116 >Category: ports >Synopsis: [PATCH] bug in PHP dependency checks >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Oct 25 12:50:18 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Dag-Erling Smørgrav >Release: FreeBSD 6.0-CURRENT i386 >Organization: >Environment: System: FreeBSD des.teleplan.no 6.0-CURRENT FreeBSD 6.0-CURRENT #7: Tue Oct 19 12:13:59 EDT 2004 des@des.teleplan.no:/usr/obj/usr/src/sys/latitude i386 head of ports tree >Description: For each element in USE_PHP, bsd.php.mk checks not only if it knows about the category but also if the corresponding port directory exists. >How-To-Repeat: On a machine with no ports tree, try for instance # porteasy -r /path/to/ports/cvs/repo -ku devel/pear-PEAR This will fail because bsd.php.mk blows up before porteasy has a chance to figure out that it needs to update devel/php4-pear: ===> pear-Archive_Tar-1.2 depends on executable: pear - not found ===> Verifying package for pear in /usr/ports/devel/php4-pear Unknown extension pcre. *** Error code 1 >Fix: The attached patch changes the test from "is this extension present" to "have I heard of this extension", and allows porteasy to work as designed. --- bsd.php.mk.diff begins here --- Index: bsd.php.mk =================================================================== RCS file: /home/pcvs/ports/Mk/bsd.php.mk,v retrieving revision 1.11 diff -u -r1.11 bsd.php.mk --- bsd.php.mk 2 Sep 2004 10:08:48 -0000 1.11 +++ bsd.php.mk 25 Oct 2004 12:19:04 -0000 @@ -332,7 +332,7 @@ zlib_DEPENDS= archivers/php${PHP_VER}-zlib . for extension in ${USE_PHP} -. if ${_USE_PHP_ALL:M${extension}} != "" && exists(${PORTSDIR}/${${extension}_DEPENDS}) +. if ${_USE_PHP_ALL:M${extension}} != "" && defined(${extension}_DEPENDS) . if defined(USE_PHP_BUILD) BUILD_DEPENDS+= ${LOCALBASE}/lib/php/${PHP_EXT_DIR}/${extension}.so:${PORTSDIR}/${${extension}_DEPENDS} . endif --- bsd.php.mk.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: