From nobody Wed Mar 11 12:54:29 2026 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fW9jB0cxHz6V7Kx for ; Wed, 11 Mar 2026 12:55:58 +0000 (UTC) (envelope-from bogorodskiy@gmail.com) Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fW9j93q0Wz4716 for ; Wed, 11 Mar 2026 12:55:57 +0000 (UTC) (envelope-from bogorodskiy@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-482f454be5bso10894625e9.0 for ; Wed, 11 Mar 2026 05:55:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773233751; x=1773838551; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=DZxo9/bzajuQELu3hEYkU5gjR21ffB5dyURBizn58m0=; b=PWxXqKKH60QtkWsxKJe3qy98yp8rd007q6j+E08W3iEIEWybOB9GE3j2AHsKDxSiT8 7sv3Thhspx49WmDgPi2Am3CD4YtZ74E1snk/50/gjMDYe2vbsxKN36xsjoh7TRKvEpb6 lgyMNerIHswsMWh6tBjwA+wHKqI6sCm0rL6VCIQlUmvu3qimKSSXuEC49eseveD7qYOn 87Ve1gpLvd6pmlL7IpfHZiAkI00H2J/RgJVIK7D1vcp3u/1Yh90OSapcNSfSg6a/1FaI +SgDyGky8+CABDp71B1UaB9dFR2bGpf+ax4stjaHeozIknVfeMBkx4KUUl4ZowsIJ5Xn MbVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773233751; x=1773838551; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=DZxo9/bzajuQELu3hEYkU5gjR21ffB5dyURBizn58m0=; b=b8N5nEjb6BCf7OrTrqCndy5Ca/6MzPXclaZxdAqUGu6R1ANZgUWOodvSYet7Itpus/ +5Amf92y2Zj5/EL5gsp1NSARQOpJWLNbt+SdwMsGkdlwoEVC4/1y/1H67pryA/nmgAV6 3O9apmYHwCv84HkivFkXWxlmMqLRs8j2XCWAkK9CaPQ7r+Ax080TmpQWXWc8M+uShoUI 4Fn6t1aTSyLOMI8Il4d+hI/meM1tGX+gSk5clIadKsG4l8Q9CTng0wGkUg0lZSHBINQr nd0Jbfis0R1xNYVQnBLIlWw45Jd7KWKcJHySCDwppqls7Gi30jW5romM9sJ29XkbFn8T Hqkg== X-Forwarded-Encrypted: i=1; AJvYcCUXLl64eQd7B0eeokXUYcPHCHFWMBxyFeiVWZMHSo/LKk0zdtVRE4g5plsWqlJUZnc0NN9l561GeOV3VH10rMsSQSjpxaDb@freebsd.org X-Gm-Message-State: AOJu0YzExGmTbvtBqhzvWyfdEM2AWJhs4mxnNgINL5bTV7Q5ynqENSJd uW0gJNNOG+GE1ahk95DxQSDf5LIeq1OrPyw4d5bAySLl0yskRd//Caa1 X-Gm-Gg: ATEYQzwR2xBw7OaPd7s4AskUfmFhRQtl2H8lzH5NOgBmBtArobDPUOcLQR4wGUip2/2 K2Xb5yhcrkLaX0TIN36l77GkAFfqfch69f8qC/1azd5RWPYWh0bdsb3jUj09iw7bzEQS2q9oI7x Aw8GzuIkxp1oJQdsagqdK/vcCly7O3kbRNNBIWNDAY1ExkSVGA/YmA0st0JIS+jYxaXVRqYHauu vzlW9BxgNpnmg8yYzmSTRHAffsOv3r31lB5sZ7EB3j2o0xNRQl9p/WbwQ4UaKz09crFro3fI5Zu UZP4sr59lNqYWwRhqV1fT6bRbsXYZbuTWUH+HaeWExsGDP0Q8PEGMgtY3+/Y1kJt6cP0VV3QocF vjoGkj+VSVM3N9rCmHrJ+A1XUK5pW+NgGtWR5oEv/LY2NWTvOJEsSesk6ftLi9x/IWHV6O99IAi hzxo3LCDhvPOSnhF0jsUYmc5R0JLGy+yxOqN72XpGYCR8wsf23/41DchWodekSMIpcMrvTIdBKl ZRPxSeehbcRatZhpg== X-Received: by 2002:a05:600c:181b:b0:485:3c09:843 with SMTP id 5b1f17b1804b1-48541a46c73mr78836635e9.9.1773233750853; Wed, 11 Mar 2026 05:55:50 -0700 (PDT) Received: from tulp (2001-1c02-1a15-3000-c218-03ff-feb5-6cc4.cable.dynamic.v6.ziggo.nl. [2001:1c02:1a15:3000:c218:3ff:feb5:6cc4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439f81aca65sm7557280f8f.17.2026.03.11.05.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 05:55:50 -0700 (PDT) Date: Wed, 11 Mar 2026 13:54:29 +0100 From: Roman Bogorodskiy To: Ronald Klop Cc: ports-committers@freebsd.org, dev-commits-ports-main@freebsd.org, dev-commits-ports-all@freebsd.org Subject: Re: git: ce3d0cc5945e - main - devel/libvirt: enable BHYVE option on arm64 Message-ID: References: <69b15c4e.211a9.177820f6@gitrepo.freebsd.org> <1365758089.1058.1773232808980@localhost> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1365758089.1058.1773232808980@localhost> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4fW9j93q0Wz4716 X-Spamd-Bar: ---- Ronald Klop wrote: > Hi, > > The commit of this line says that bhyveload is needed during the build and that is why it checks for it. > https://cgit.freebsd.org/ports/commit/devel/libvirt/Makefile?id=751fd2a4a2fcd48fc1f80b1a2d20848f35a924a3 > > Your commit message does not hint on if bhyveload is not needed for the build anymore. > Can you elaborate a little on this? Or point to the change in libvirt that makes it not use bhyveload anymore? > > NB: I totally trust that you compiled and checked the port on aarch64. So the cause is probably fixed upstream. It would just very nicely close the documentation loop if the commit referred to that fix in libvirt. > > Regards, > Ronald. Hi Ronald, Yes, it was addressed in libvirt with this commit: https://gitlab.com/libvirt/libvirt/-/commit/f7abafdd05f300a069eb888db166c1a50deef7d4 > Van: Roman Bogorodskiy > Datum: woensdag, 11 maart 2026 13:13 > Aan: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org > Onderwerp: git: ce3d0cc5945e - main - devel/libvirt: enable BHYVE option on arm64 > > > > The branch main has been updated by novel: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=ce3d0cc5945ee374d845ae16351999d43ca7cd42 > > > > commit ce3d0cc5945ee374d845ae16351999d43ca7cd42 > > Author: Roman Bogorodskiy > > AuthorDate: 2026-03-10 17:14:30 +0000 > > Commit: Roman Bogorodskiy > > CommitDate: 2026-03-11 12:11:25 +0000 > > > > devel/libvirt: enable BHYVE option on arm64 > > Currently, the BHYVE option is available only if "/usr/sbin/bhyveload" > > is present. However, bhyveload(8) is not present on arm64. > > To make the BHYVE option available on arm64 too, update > > the condition to check for the "/usr/sbin/bhyve" path instead. > > Sponsored by: The FreeBSD Foundation > > --- > > devel/libvirt/Makefile | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/devel/libvirt/Makefile b/devel/libvirt/Makefile > > index 9ef329749e89..5520a090820b 100644 > > --- a/devel/libvirt/Makefile > > +++ b/devel/libvirt/Makefile > > @@ -1,5 +1,6 @@ > > PORTNAME= libvirt > > DISTVERSION= 12.1.0 > > +PORTREVISION= 1 > > CATEGORIES= devel > > MASTER_SITES= http://libvirt.org/sources/ \ > > ftp://libvirt.org/libvirt/ > > @@ -22,7 +23,7 @@ RUN_DEPENDS= dnsmasq:dns/dnsmasq > > OPTIONS_DEFINE= DOCS NLS NSS QEMU READLINE SASL SLIRP LIBSSH LIBSSH2 ZFS > > OPTIONS_DEFAULT= READLINE LIBSSH LIBSSH2 ZFS > > OPTIONS_DEFINE_amd64= XEN > > -.if exists(/usr/sbin/bhyveload) > > +.if exists(/usr/sbin/bhyve) > > OPTIONS_DEFINE+= BHYVE > > OPTIONS_DEFAULT+= BHYVE SLIRP > > .else > > > > > > > >