From owner-freebsd-net@FreeBSD.ORG Sat Dec 1 22:31:03 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9E1268B6; Sat, 1 Dec 2012 22:31:03 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by mx1.freebsd.org (Postfix) with ESMTP id 827428FC08; Sat, 1 Dec 2012 22:31:02 +0000 (UTC) Received: by mail-wg0-f52.google.com with SMTP id 12so842540wgh.31 for ; Sat, 01 Dec 2012 14:31:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=eU+c45EwjuquaExmzWfppfihsfdDJXcE+pDgB6v4jF0=; b=bume6SWuoAKXnD28d6JLEeLi1V83JdQxY+WXz9HbJ+kaspeb+5L19UM2FHj7Zfa4xO egYeFMzlf5I6Tu/j+iLIP75Z/mcqZsViur8ZxExjvfjiSoX+mzypdZi1iBhPGYa7SK3A 3oV5WXkxywAdlSFQ+3Dt2AH89NuLMYi2GoHBY/RDpCpWU6d2KkjG2T5PZBRA8T2V0PZC SG/xi/yGECp8ei4GttpQRJe8+SyPDhwT62oLctodn4USuyOFM+0BLmQ2qosvM3lOJEH6 8p4TW2MBbvR5nzZ9v3FgL6iHcjG82e6yJ4LForozNk1OE08FBd1za41zFiIsT1gyCvlb GCng== Received: by 10.216.206.212 with SMTP id l62mr1719743weo.218.1354401061237; Sat, 01 Dec 2012 14:31:01 -0800 (PST) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPS id u6sm5379217wif.2.2012.12.01.14.30.58 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 01 Dec 2012 14:30:59 -0800 (PST) Date: Sat, 1 Dec 2012 23:30:49 +0100 From: Mateusz Guzik To: Hiroki Sato Subject: Re: LOR in rtsock/ifnet Message-ID: <20121201223049.GA12120@dft-labs.eu> References: <20121201133609.GA5450@dft-labs.eu> <20121201.225004.2232262673795057435.hrs@allbsd.org> <20121202.065436.1086216324076847740.hrs@allbsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20121202.065436.1086216324076847740.hrs@allbsd.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: ae@FreeBSD.org, adrian@FreeBSD.org, rpaulo@FreeBSD.org, freebsd-net@FreeBSD.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Dec 2012 22:31:03 -0000 On Sun, Dec 02, 2012 at 06:54:36AM +0900, Hiroki Sato wrote: > Hiroki Sato wrote > in <20121201.225004.2232262673795057435.hrs@allbsd.org>: > > hr> Mateusz Guzik wrote > hr> in <20121201133609.GA5450@dft-labs.eu>: > hr> > hr> mj> On Fri, Nov 30, 2012 at 11:16:25PM -0800, Adrian Chadd wrote: > hr> mj> > Mateusz: are you sure it's that commit? > hr> mj> > > hr> mj> > hr> mj> Yes, I double-checked right now. > hr> mj> > hr> mj> > I still get this in -HEAD: > hr> mj> > > hr> mj> > hr> mj> Maybe I expressed myself incorrectly, I meant to say that LOR started > hr> mj> showing up since r243187. > hr> mj> > hr> mj> The code is still in head and no fixes were comitted (that I know of at > hr> mj> least), so I guess that you seeing this LOR on head is expected. :) > hr> > hr> Thanks for the info. I am investigating this now. > > Can anyone test the attached patch and let me know if the LOR > persists or not? > I got the following build failure: /srv/repos/freebsd/sys/netinet6/in6_cksum.c:69:22: error: sys/vnet.h: No such file or directory In file included from /srv/repos/freebsd/sys/netinet6/in6_cksum.c:72: /srv/repos/freebsd/sys/netinet6/scope6_var.h:45: error: expected declaration specifiers or '...' before 'deembed_scopeid' cc1: warnings being treated as errors /srv/repos/freebsd/sys/netinet6/scope6_var.h:45: warning: data definition has no type or storage class /srv/repos/freebsd/sys/netinet6/scope6_var.h:45: warning: type defaults to 'int' in declaration of 'VNET_DECLARE' However after changing sys/vnet.h to net/vnet.h the kernel compiled fine and LOR is gone. -- Mateusz Guzik