From owner-freebsd-ports@FreeBSD.ORG Wed Mar 11 13:51:59 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A4CD61065672 for ; Wed, 11 Mar 2009 13:51:59 +0000 (UTC) (envelope-from eitanadlerlist@gmail.com) Received: from mail-gx0-f176.google.com (mail-gx0-f176.google.com [209.85.217.176]) by mx1.freebsd.org (Postfix) with ESMTP id 458DC8FC1C for ; Wed, 11 Mar 2009 13:51:59 +0000 (UTC) (envelope-from eitanadlerlist@gmail.com) Received: by gxk24 with SMTP id 24so33596gxk.19 for ; Wed, 11 Mar 2009 06:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:openpgp:content-type:content-transfer-encoding; bh=LlAlvuxcQQLtTmK8g0agf7cw7avimsbxhO4XlLAfnTU=; b=aFVM4G5O2w56Bfz+xCYvKfbqLZ4GH+lrDgTd2FFpUENNnMNcoCO312CQotZXSXnxMm hJnaNf+k6OnSuvXZde//yvYWgitN3AWNWio1ugl361uSZ5PkSM5FZTOPb84gA+oJQnHv ypDmARDJunOjkFFQNRZjzjrE1EYQKfgpQzDKQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:openpgp:content-type :content-transfer-encoding; b=SW4x8Tp+tytwr//goydp7SnunSD/EQTMxQ8LHyz1Op2am5EJeD8zVuQP3suZoPwRu2 0aydh3z4+T/JcD1j32qVUpkIw+ZBG+F5MtFeZKFuGslKaipLdWc7tVgrd8gYXQ14i5Wt oFydIQEP2u1c3GySXlmH9RvsWEwLsCe9NOsLE= Received: by 10.143.31.4 with SMTP id i4mr3700931wfj.102.1236779518171; Wed, 11 Mar 2009 06:51:58 -0700 (PDT) Received: from aargh.lan (ool-182fcc8b.dyn.optonline.net [24.47.204.139]) by mx.google.com with ESMTPS id 20sm14308706wfi.32.2009.03.11.06.51.56 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 11 Mar 2009 06:51:57 -0700 (PDT) Message-ID: <49B7C206.1040508@gmail.com> Date: Wed, 11 Mar 2009 09:52:06 -0400 From: Eitan Adler User-Agent: Mozilla (X11; U; FreeBSD i386; en-US; ) Gecko Thunderbird Mnenhy/0.7.6.666 MIME-Version: 1.0 To: avg@icyb.net.ua References: <49B6A827.50705@icyb.net.ua> <49B7BE84.3050106@gmail.com> <49B7BFC8.3010202@icyb.net.ua> In-Reply-To: <49B7BFC8.3010202@icyb.net.ua> X-Enigmail-Version: 0.95.7 OpenPGP: id=E9C2CCD1; url=pgp.mit.edu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-ports@FreeBSD.ORG Subject: Re: request for a new port review [memtest86+] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Mar 2009 13:51:59 -0000 Andriy Gapon wrote: > on 11/03/2009 15:37 Eitan Adler said the following: >> Andriy Gapon wrote: >>> Guys, >>> >>> could you please review the below port for correctness, style and general approach >>> taken by me. >> http://isis.poly.edu/~eitan/files/patch-memtest86+-port.diff >> Apply this patch then install the port "portlint" and run portlint -CNA. >> >> Always use tabs - not spaces. > > Something must have been screwed during transfer, I do have tabs not spaces here - > otherwise makefile syntax would be incorrect, nothing would work and I wouldn't > even attempt to submit such a mess. > These are the commands I used to fetch and extract: $fetch http://www.icyb.net.ua/~avg/memtest86+.port.shar.txt $sh memtest86+.port.shar.txt $cd memtest86+ $portlint -CNA Either way run portlint -CNA. When this passes submit a PR with the port. Also since you don't have spaces my diff won't apply but I think you should change BOOT_DIR= /boot/opt to BOOT_DIR?= /boot/opt so the location can be specified by the user. -- Eitan Adler "Security is increased by designing for the way humans actually behave." -Jakob Nielsen