From owner-cvs-src@FreeBSD.ORG Sun Feb 5 17:47:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B406916A420; Sun, 5 Feb 2006 17:47:27 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 599B543D49; Sun, 5 Feb 2006 17:47:27 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k15HlRLH058125; Sun, 5 Feb 2006 17:47:27 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k15HlRfa058124; Sun, 5 Feb 2006 17:47:27 GMT (envelope-from netchild) Message-Id: <200602051747.k15HlRfa058124@repoman.freebsd.org> From: Alexander Leidinger Date: Sun, 5 Feb 2006 17:47:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/usb uaudio.c src/sys/dev/sound/pcm sound.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Feb 2006 17:47:27 -0000 netchild 2006-02-05 17:47:26 UTC FreeBSD src repository Modified files: sys/dev/sound/usb uaudio.c sys/dev/sound/pcm sound.c Log: Convert NULL checks into KASSERT (and move them before the first dereferencing) since a NULL value would be a bug here. Note: Both affected functions look very similar. A refactoring may be beneficial. CID: 483, 485 Found with: Coverity Prevent(tm) Discussed with: ariff MFC after: 5 days Revision Changes Path 1.98 +20 -18 src/sys/dev/sound/pcm/sound.c 1.20 +11 -10 src/sys/dev/sound/usb/uaudio.c