Date: Thu, 27 Oct 2016 08:17:17 -0200 From: Renato Botelho <garga@FreeBSD.org> To: Kurt Jaeger <lists@opsec.eu> Cc: Jochen Neumeister <joneum@bsdproject.de>, "freebsd-ports@freebsd.org" <freebsd-ports@freebsd.org> Subject: Re: make makepatch Message-ID: <62FE737B-001E-4DA7-95E7-1875CA70A8C6@FreeBSD.org> In-Reply-To: <20161027062029.GG51420@home.opsec.eu> References: <730bd5a8-d6c2-7e8f-5240-b7d4b6209884@bsdproject.de> <20161027062029.GG51420@home.opsec.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 27 Oct 2016, at 04:20, Kurt Jaeger <lists@opsec.eu> wrote: >=20 > Hi! >=20 >> # portlint >> WARN: /usr/home/joneum/dev/ports/net/wpa_gui/files/patch-wpa_ctrl.c: >> patch was not generated using ``make makepatch''. It is recommended = to >> use ``make makepatch'' when you need to [re-]generate a patch to = ensure >> proper patch format. >> 0 fatal errors and 1 warning found. >>=20 >> okay, i use "make makepatch", and copy the files from >> "work/.makepatch-tmp/archived-patches" to the "/files" folder, and = start >> portlint. But, the same. >>=20 >> what am i doing wrong? >=20 > make makepatch places the corrected files into files/ and > the prevision version to work/.makepatch-tmp/archived-patches. >=20 > So, I'd suggest: >=20 > make patch > make makepatch > mv work work.old > portlint -AC >=20 > and if portlint is silent, and all the necessary patches are in = files/, > you're done. I only suggest to replace =E2=80=98make patch=E2=80=99 by: # make extract do-patch There are several ports that changes files using REINPLACE_CMD in = post-patch: target, this way you will not run post-patch: and will not = risky to end up converting REINPLACE_CMD into static patches. -- Renato Botelho
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?62FE737B-001E-4DA7-95E7-1875CA70A8C6>