From owner-svn-src-all@FreeBSD.ORG  Mon Dec  1 13:07:51 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 91EE96E3;
 Mon,  1 Dec 2014 13:07:51 +0000 (UTC)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
 by mx1.freebsd.org (Postfix) with ESMTP id 515B6C0F;
 Mon,  1 Dec 2014 13:07:50 +0000 (UTC)
Received: from nine.des.no (smtp.des.no [194.63.250.102])
 by smtp-int.des.no (Postfix) with ESMTP id 2B3C1A60C;
 Mon,  1 Dec 2014 13:07:50 +0000 (UTC)
Received: by nine.des.no (Postfix, from userid 1001)
 id 423471776; Mon,  1 Dec 2014 14:07:45 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Bryan Venteicher <bryanv@FreeBSD.org>
Subject: Re: svn commit: r273331 - in head: sbin/ifconfig share/man/man4
 sys/conf sys/modules sys/modules/if_vxlan sys/net sys/sys
References: <201410201442.s9KEggqt096167@svn.freebsd.org>
 <86zjb7frz0.fsf@nine.des.no>
Date: Mon, 01 Dec 2014 14:07:45 +0100
In-Reply-To: <86zjb7frz0.fsf@nine.des.no> ("Dag-Erling =?utf-8?Q?Sm=C3=B8r?=
 =?utf-8?Q?grav=22's?= message of
 "Mon, 01 Dec 2014 13:57:07 +0100")
Message-ID: <86vblvfrha.fsf@nine.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Dec 2014 13:07:51 -0000

Dag-Erling Sm=C3=B8rgrav <des@des.no> writes:
> Bryan Venteicher <bryanv@FreeBSD.org> writes:
> > Log:
> >   Add vxlan interface
> >   [...]
> This breaks the existing "group" command, which means I now have
> machines that won't boot without manual intervention because their
> firewall rulesets rely on interface groups.

I added code to cmd_register() in ifconfig.c to warn about duplicate
commands.  Here is a complete list of pre-existing commands which the
vxlan code shadows:

ifconfig: duplicate command: group
ifconfig: duplicate command: timeout
ifconfig: duplicate command: maxaddr
ifconfig: duplicate command: learn
ifconfig: duplicate command: -learn
ifconfig: duplicate command: flush
ifconfig: duplicate command: flushall

so, in addition to breaking interface groups, it breaks bridge
interfaces.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no