From owner-freebsd-bugs  Tue Aug 14 20:49: 5 2001
Delivered-To: freebsd-bugs@freebsd.org
Received: from iatl0x01.coxmail.com (iatl0x02.coxmail.com [206.157.225.11])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5C0C537B434; Tue, 14 Aug 2001 20:48:56 -0700 (PDT)
	(envelope-from mheffner@novacoxmail.com)
Received: from enterprise.muriel.penguinpowered.com ([209.249.161.66])
          by iatl0x01.coxmail.com
          (InterMail vK.4.03.02.00 201-232-124 license eaa2928f5bcba31507d4d280f1027278)
          with ESMTP
          id <20010815034855.PLOT70.iatl0x01@enterprise.muriel.penguinpowered.com>;
          Tue, 14 Aug 2001 23:48:55 -0400
Message-ID: <XFMail.20010814234524.mheffner@novacoxmail.com>
X-Mailer: XFMail 1.5.0 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Date: Tue, 14 Aug 2001 23:45:24 -0400 (EDT)
Reply-To: Mike Heffner <mheffner@vt.edu>
From: Mike Heffner <mheffner@novacoxmail.com>
To: Andre Albsmeier <andre.albsmeier@mchp.siemens.de>
Subject: Re: bin/21152: @monthly entry in crontab is run every day
Cc: "Alexander S. Usov" <usov@ukr.net>,
	freebsd-gnats-submit@freebsd.org,
	FreeBSD-bugs <freebsd-bugs@freebsd.org>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

Can you see whether the following, untested, patch works? It should fix the
@monthly and @weekly entries. Also, it should fix the @yearly/@annually entry
so that it doesn't execute daily during January.


Thanks,

Mike

-- 
  Mike Heffner         <mheffner@[acm.]vt.edu>
  Fredericksburg, VA       <mikeh@FreeBSD.org>




Index: entry.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/cron/lib/entry.c,v
retrieving revision 1.14
diff -u -r1.14 entry.c
--- entry.c     2001/07/18 11:49:45     1.14
+++ entry.c     2001/08/15 03:40:59
@@ -156,6 +156,7 @@
                        bit_set(e->dom, 0);
                        bit_set(e->month, 0);
                        bit_nset(e->dow, 0, (LAST_DOW-FIRST_DOW+1));
+                       e->flags |= DOW_STAR;
                } else if (!strcmp("monthly", cmd)) {
                        Debug(DPARS, ("load_entry()...monthly shortcut\n"))
                        bit_set(e->minute, 0);
@@ -163,11 +164,13 @@
                        bit_set(e->dom, 0);
                        bit_nset(e->month, 0, (LAST_MONTH-FIRST_MONTH+1));
                        bit_nset(e->dow, 0, (LAST_DOW-FIRST_DOW+1));
+                       e->flags |= DOW_STAR;
                } else if (!strcmp("weekly", cmd)) {
                        Debug(DPARS, ("load_entry()...weekly shortcut\n"))
                        bit_set(e->minute, 0);
                        bit_set(e->hour, 0);
                        bit_nset(e->dom, 0, (LAST_DOM-FIRST_DOM+1));
+                       e->flags |= DOM_STAR;
                        bit_nset(e->month, 0, (LAST_MONTH-FIRST_MONTH+1));
                        bit_set(e->dow, 0);
                } else if (!strcmp("daily", cmd) || !strcmp("midnight", cmd)) {


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message