From nobody Tue Aug 22 16:18:12 2023 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RVZKJ0Jmpz4r5Jd for ; Tue, 22 Aug 2023 16:18:44 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RVZKH5kxbz4VpX; Tue, 22 Aug 2023 16:18:43 +0000 (UTC) (envelope-from mavbsd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-58d70c441d5so52065097b3.2; Tue, 22 Aug 2023 09:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692721122; x=1693325922; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:sender :from:to:cc:subject:date:message-id:reply-to; bh=l5EurCr6pG0MIN1QE7aSHthGy31lapUBJ0Li5/kg9Ic=; b=J7EpGBfHSlV4oxEW7WYyMFpEc9RwVR/uUpVH+rflx7yTho7IJv9SL4vE4z8uph6dIg /joZ586hKpndoEQIhtEPN+1NjYZTM5MJV2K1rtoiet3q526/jaUIsWMrS8eZ69QQQP3k 42RhSpkg0+ouTjUNtk+lu+rvQVfUQVQW+QASXoNlJJn5d+NlnW0urRZhwXtJLTpB53k2 3+egLTab/F1yyVunuK4DwQDUWNzYXwDDSbtOgr5aU7+PbZLdb7rj8G+Lg70iu3n0DO6S TAWrHACVa9Uvhc4Do3Dd0frj1DL7Cdh9/WKg+FRduIBdBAAMkNvB7xVkJ/IaQP5tcE3O iIWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692721122; x=1693325922; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l5EurCr6pG0MIN1QE7aSHthGy31lapUBJ0Li5/kg9Ic=; b=PIutYLMdjop5CggqMmSvbL7oVbTpAkzQi6NJ4o7w8rrtCMLf0CS2u67BLWPFE+UnWt 2iPjIy7pNUPc1f4XbvqvGFfcTVZ8p5eKI3eU4uKWjf/j2gmEzD1D7GgnZAdV2rEa1y6t OZwHXjm657cav4OrW/465y1QihVzkmzqaIUJOtD+QG65jULSopJxZ+D4whzt1yAXXu19 lhzp0SpAm9rjQBXmn8aJu5c6K4hwfrjbsf+MLMTWgm/3zixXNemJHLmIUf0S4PlJwC3a nh4Ws8qbXY97l3TGDC7aZmc1PWs3X7biw5LsVktw0WJRM2ZlwQlCOT1v3jQ4zay7eQ8g LPEg== X-Gm-Message-State: AOJu0YyjUjTxjSUJeHlMSTsccah/dnZ1KAk0+e+r94m1yAuthgAin/Fn uLMgAsucuUGFvaZ7yQx1G+AGhnKsvj4= X-Google-Smtp-Source: AGHT+IE5bNJEsqXtQxOB8P1vHXwUo0WjXeZwSok4ttaGmqMYXHDDkkpDgspRlyHw0t+lAE96pExFwQ== X-Received: by 2002:a0d:e889:0:b0:586:c1fc:f307 with SMTP id r131-20020a0de889000000b00586c1fcf307mr11212493ywe.0.1692721122610; Tue, 22 Aug 2023 09:18:42 -0700 (PDT) Received: from [10.230.45.5] ([38.32.73.2]) by smtp.gmail.com with ESMTPSA id i194-20020a816dcb000000b0057042405e2csm2858921ywc.71.2023.08.22.09.18.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Aug 2023 09:18:41 -0700 (PDT) Message-ID: Date: Tue, 22 Aug 2023 12:18:12 -0400 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Martin Matuska Cc: =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= , current@freebsd.org, Mateusz Guzik References: <86leeltqcb.fsf@ltc.des.no> <86h6p4s64h.fsf@ltc.des.no> <86a5utrafp.fsf@ltc.des.no> <86350kqokl.fsf@ltc.des.no> <86y1icp95t.fsf@ltc.des.no> <86ttt0p8wv.fsf@ltc.des.no> <197ead1e-210a-6be6-7e24-5c56b14bb777@FreeBSD.org> <86350hpiby.fsf@ltc.des.no> <0fd64567-59cd-9276-cc0c-17a09611f11a@FreeBSD.org> <20230822102622.Horde.tUEwNRTMDn0AjOBiO1UB7OX@webmail.your-server.de> From: Alexander Motin Subject: Re: ZFS deadlock in 14 In-Reply-To: <20230822102622.Horde.tUEwNRTMDn0AjOBiO1UB7OX@webmail.your-server.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4RVZKH5kxbz4VpX X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] Hi Martin, I am waiting for final test results from George Wilson and then will request quick merge of both to zfs-2.2-release branch. Unfortunately there are still not many reviewers for the PR, since the code is not trivial, but at least with the test reports Brian Behlendorf and Mark Maybee seem to be OK to merge the two PRs into 2.2. If somebody else have tested and/or reviewed the PR, you may comment on it. On 22.08.2023 04:26, Martin Matuska wrote: > as 15107 is a prerequisite for 15122, > would it be possible to have https://github.com/openzfs/zfs/pull/15107 > merged into the OpenZFS zfs-2.2-release branch (and of course later 15122)? > > If the patches help I can cherry-pick them into main. > > Alexander Motin wrote: > >> On 17.08.2023 15:41, Dag-Erling Smørgrav wrote: >>> Alexander Motin writes: >>>> Trying to run your test (so far without reproduction) I see it >>>> producing a substantial amount of ZIL writes.  The range of commits >>>> you reduced the scope to so far includes my ZIL locking refactoring, >>>> where I know for sure are some deadlocks.  I am already waiting for 3 >>>> weeks now for reviews and tests for PR that should fix it: >>>> https://github.com/openzfs/zfs/pull/15122 .  It would be good if you >>>> could test it, though it seems to depend on few more earlier patches >>>> not merged to FreeBSD yet. >>> >>> Do you have a FreeBSD branch with your patch applied? >> >> I don't have a FreeBSD branch, but these two patches apply clean and >> build on top of today's FreeBSD main branch: >> >> https://github.com/openzfs/zfs/pull/15107 >> https://github.com/openzfs/zfs/pull/15122 >> >> And if you still experience the issue, please show all stacks, or at >> least include ZFS sync threads. -- Alexander Motin