From owner-freebsd-gnome@FreeBSD.ORG Wed Nov 17 12:34:22 2004 Return-Path: Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF32016A4CE for ; Wed, 17 Nov 2004 12:34:22 +0000 (GMT) Received: from smtp1.jazztel.es (smtp1.jazztel.es [62.14.3.161]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1C28A43D41 for ; Wed, 17 Nov 2004 12:34:22 +0000 (GMT) (envelope-from josemi@freebsd.jazztel.es) Received: from antivirus by smtp1.jazztel.es with antivirus id 1CUP0x-0000u9-00 Wed, 17 Nov 2004 13:34:23 +0100 Received: from [212.106.252.3] (helo=rguez.homeunix.net) by smtp1.jazztel.es with esmtp id 1CUP0x-0000tb-00 Wed, 17 Nov 2004 13:34:23 +0100 Received: from redesjm.local (orion.redesjm.local [192.168.254.16]) by rguez.homeunix.net (8.13.1/8.13.1) with ESMTP id iAHCY5B4001791; Wed, 17 Nov 2004 13:34:05 +0100 (CET) (envelope-from freebsd@redesjm.local) Received: from localhost (localhost [[UNIX: localhost]]) by redesjm.local (8.13.1/8.13.1/Submit) id iAHCY6p1024325; Wed, 17 Nov 2004 13:34:06 +0100 (CET) (envelope-from freebsd@redesjm.local) From: Jose M Rodriguez To: Michael Johnson Date: Wed, 17 Nov 2004 13:34:05 +0100 User-Agent: KMail/1.7.1 References: <200411170947.45235.freebsd@redesjm.local> <200411171158.11611.freebsd@redesjm.local> <4625EB54-388D-11D9-8B95-000A95BB7150@ahze.net> In-Reply-To: <4625EB54-388D-11D9-8B95-000A95BB7150@ahze.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200411171334.06166.freebsd@redesjm.local> X-AntiVirus: checked by AntiVir Milter (version: 1.1; AVE: 6.28.0.12; VDF: 6.28.0.76; host: antares.redesjm.local) X-Virus-Scanned: by antivirus cc: freebsd-gnome@freebsd.org Subject: Re: About firefox new layout X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Nov 2004 12:34:23 -0000 El Mi=E9rcoles, 17 de Noviembre de 2004 12:39, Michael Johnson escribi=F3: > On Nov 17, 2004, at 5:58 AM, Jose M Rodriguez wrote: > > El Mi=E9rcoles, 17 de Noviembre de 2004 10:52, Michael Johnson=20 escribi=F3: > >> On Nov 17, 2004, at 3:47 AM, Jose M Rodriguez wrote: > >>> El Mi=E9rcoles, 17 de Noviembre de 2004 05:52, Joe Marcus Clarke > >>> > >>> escribi=F3: > >>>> Jose M Rodriguez wrote: > >> > >> ---- snip ---- > >> [...] > >> > >>>> | This must be not only easier, but also safer. > >> > >> how is this easier and safer? > > > > The most common way to install firefox is with firefox[-config] and > > run-mozilla.sh in the same dir. This is the most proven layout > > from the mozilla comunity. > > The default firefox install installs firefox in bin/firefox well, This is the build deafult, but is more common see this as in=20 mozilla (in firefox/mozilla/thunderbird in different unix variants). In fact, this is the first test, see if there is an executable=20 run-mozilla.sh in the same dir as "$0". > [...] > > > > So we have our FreeBSD related stuff in ${PREFIX}/bin/firefox and > > the mainstream mozilla stuff (without patches) in > > ${PREFIX}/lib/firefox/firefox > > This shouldn't matter because before the last commit bin/firefox was > linked to lib/firefox/lib/firefox-VERSION/bin/firefox > This isn't needed. It's more confortable to maintain > >>> - install firefox[-config] under ${PREFIX}/lib/firefox > >> > >> Why install firefox[-config] in PREFIX/lib/firefox? > >> I don't see any reason to do this. It's not like we have > >> www/firefox-devel or anything > >> that would conflict. > > > > Please, read above and see how ${PREFIX}/bin/mozilla and > > ${PREFIX}/lib/mozilla/mozilla work in the same way. > > The major difference is bin/mozilla script has mail knobs > and firefox doesn't do mail. At last here: mozilla script have 33 lines and a clean design firefox script have 264 lines and more complexity > > >>> - install a brand new ${FILESDIR}/firefox.sh as > >>> ${PREFIX}/bin/firefox > >> > >> So basically the only thing you want is when you open 2 sessions > >> of firefox the > >> 2nd session doesn't open but opens a new tab? > > > > Not really. This may be taken with or without script split. > > > > I can send-pr to what is prefer: > > - more patching to patch-browser_app_mozilla.in > > - script split. > > I still don't understand why it's important to install firefox in > lib/firefox > and why we can't just edit patch-browser_app_mozilla.in ? This is not really the case. We are talking about split the actual /usr/X11R6/bin/firefox script in=20 two. One /usr/X11R6/bin/firefox and one /usr/X11R6/lib/firefox/firefox. /usr/X11R6/lib/firefox/firefox may be directly inherit from mozilla. We=20 use it only in first launchs of firefox. And we don't have to maintain=20 a local patch in the case mozilla change his script (less maintain=20 effort). /usr/X11R6/bin/firefox must be installed from ${FILESDIR}. Or even use=20 an external one and run-depends on it. We can do here just what the FreeBSD project need and the use of the=20 remote protocol, without seen the real complexity of a mozilla-app=20 launch. > > Can you please explain why this is important, I still don't > understand why > installing firefox, firefox-config in lib/firefox is so important, or > why it matters? > We can install firefox-config in any place. But it's in most cases=20 installed in the same dir as firefox We can install firefox in any place. But if we go install a distro=20 specific script under ${PREFIX}/bin/ with the same name,=20 ${PREFIX}/lib/firefox/ seems a good candidate. Also, if fiefox and run-mozilla.sh don't live in the same dir, you need=20 joe patch-browser_app_mozilla.in > > Also, if we go to script split, this must reach thunderbird also. > > Why? > Use the same method in all mozilla apps. A distro specific script=20 linking to a mozilla distributed script through sh exec. But I think this can go even far. If nobody seems any major objection=20 to the script split concept, A more coordinate operation may be=20 reachable. But this may require time. Please, put this in quarantine. =2D- josemi > >> Michael > > > > -- > > josemi