Date: Thu, 29 Jun 2006 10:17:03 GMT From: Florent Thoumie <flz@FreeBSD.org> To: ohauer@gmx.de, flz@FreeBSD.org, freebsd-rc@FreeBSD.org, flz@FreeBSD.org Subject: Re: conf/98603: [PATCH] /etc/rc.d/ramdisk + ramdisk-own replacement Message-ID: <200606291017.k5TAH3AO057139@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
Synopsis: [PATCH] /etc/rc.d/ramdisk + ramdisk-own replacement
State-Changed-From-To: open->feedback
State-Changed-By: flz
State-Changed-When: Thu Jun 29 10:08:37 UTC 2006
State-Changed-Why:
I have some concerns about your patch:
x ramdisk{,-own} scripts have been superseded by mdconfig{,2} in HEAD
x you're using some commands which are not available soon enough like
chown, chmod, ...; that was the only reason why there were two scripts
in a first place
x you're adding a help command, such things goes either in rc.conf(5)
or in /etc/defaults/rc.conf
x you're printing debug stuff inconditionnally, see debug/info
subroutines in rc.subr
Anyway, please test mdconfig scripts, I'm going to remove those ramdisk
scripts from HEAD in a couple of minutes.
Responsible-Changed-From-To: freebsd-rc->flz
Responsible-Changed-By: flz
Responsible-Changed-When: Thu Jun 29 10:08:37 UTC 2006
Responsible-Changed-Why:
Grab this one.
http://www.freebsd.org/cgi/query-pr.cgi?pr=98603
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200606291017.k5TAH3AO057139>