From owner-freebsd-rc@FreeBSD.ORG  Thu Jun 29 10:43:41 2006
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
X-Original-To: freebsd-rc@hub.freebsd.org
Delivered-To: freebsd-rc@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6BAA516A57C;
	Thu, 29 Jun 2006 10:43:41 +0000 (UTC) (envelope-from flz@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5D70C44652;
	Thu, 29 Jun 2006 10:17:03 +0000 (GMT) (envelope-from flz@FreeBSD.org)
Received: from freefall.freebsd.org (flz@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k5TAH3eW057143;
	Thu, 29 Jun 2006 10:17:03 GMT
	(envelope-from flz@freefall.freebsd.org)
Received: (from flz@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k5TAH3AO057139;
	Thu, 29 Jun 2006 10:17:03 GMT (envelope-from flz)
Date: Thu, 29 Jun 2006 10:17:03 GMT
From: Florent Thoumie <flz@FreeBSD.org>
Message-Id: <200606291017.k5TAH3AO057139@freefall.freebsd.org>
To: ohauer@gmx.de, flz@FreeBSD.org, freebsd-rc@FreeBSD.org, flz@FreeBSD.org
Cc: 
Subject: Re: conf/98603: [PATCH] /etc/rc.d/ramdisk + ramdisk-own replacement
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
	<freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jun 2006 10:43:41 -0000

Synopsis: [PATCH] /etc/rc.d/ramdisk + ramdisk-own replacement

State-Changed-From-To: open->feedback
State-Changed-By: flz
State-Changed-When: Thu Jun 29 10:08:37 UTC 2006
State-Changed-Why: 
I have some concerns about your patch:
x ramdisk{,-own} scripts have been superseded by mdconfig{,2} in HEAD
x you're using some commands which are not available soon enough like
chown, chmod, ...; that was the only reason why there were two scripts
in a first place
x you're adding a help command, such things goes either in rc.conf(5)
or in /etc/defaults/rc.conf
x you're printing debug stuff inconditionnally, see debug/info
subroutines in rc.subr

Anyway, please test mdconfig scripts, I'm going to remove those ramdisk
scripts from HEAD in a couple of minutes.


Responsible-Changed-From-To: freebsd-rc->flz
Responsible-Changed-By: flz
Responsible-Changed-When: Thu Jun 29 10:08:37 UTC 2006
Responsible-Changed-Why: 
Grab this one.

http://www.freebsd.org/cgi/query-pr.cgi?pr=98603