From owner-freebsd-bugs@FreeBSD.ORG Mon Oct 1 10:40:06 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A6D01106564A for ; Mon, 1 Oct 2012 10:40:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 746898FC0C for ; Mon, 1 Oct 2012 10:40:06 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q91Ae6Of097932 for ; Mon, 1 Oct 2012 10:40:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q91Ae6V3097922; Mon, 1 Oct 2012 10:40:06 GMT (envelope-from gnats) Date: Mon, 1 Oct 2012 10:40:06 GMT Message-Id: <201210011040.q91Ae6V3097922@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Ilya A. Arkhipov" Cc: Subject: Re: bin/172112: [patch] Fix for incorrect work: pw user show 0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Ilya A. Arkhipov" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2012 10:40:06 -0000 The following reply was made to PR bin/172112; it has been noted by GNATS. From: Ilya A. Arkhipov To: bug-followup@freebsd.org Cc: Subject: Re: bin/172112: [patch] Fix for incorrect work: pw user show 0 Date: Mon, 01 Oct 2012 14:32:08 +0400 Hi All, We need remove atoi() because after http://svnweb.freebsd.org/base/head/usr.sbin/pw/pw_user.c?r1=42287&r2=43780 it's no need there. We already know a_name->val has only digits or no, and have all checks on this. Please fix me if I'm wrong. -- With Best Regards, Ilya A. Arkhipov