From owner-freebsd-current@FreeBSD.ORG Wed Aug 22 13:17:57 2007 Return-Path: Delivered-To: current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8AE5016A419; Wed, 22 Aug 2007 13:17:57 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 5EE4B13C4A6; Wed, 22 Aug 2007 13:17:57 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id E508F4A784; Wed, 22 Aug 2007 09:17:56 -0400 (EDT) Date: Wed, 22 Aug 2007 14:17:56 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Diomidis Spinellis In-Reply-To: <46C96EFE.6070400@aueb.gr> Message-ID: <20070822141726.E64808@fledge.watson.org> References: <20070819214953.I1099@fledge.watson.org> <46C8C2E6.9030405@aueb.gr> <20070819164823.H568@10.0.0.1> <46C96EFE.6070400@aueb.gr> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: attilio@FreeBSD.ORG, Jeff Roberson , jeff@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: Crash in accounting code: encode_long(), due to bad rusage data? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2007 13:17:57 -0000 On Mon, 20 Aug 2007, Diomidis Spinellis wrote: > Jeff Roberson wrote: >>> Robert Watson wrote: >>>> I recently upgraded two servers from FreeBSD 6-STABLE to FreeBSD >>>> 7-CURRENT in anticipation of the forthcoming release. Both of them run >>>> with accounting enabled at all times. When a large pine session was >>>> exiting on one of the two boxes, I ran into the following panic: >>>> >>>> panic: encode_long: -ve value -32749 > [...] >> What do you think about simply putting in a max value if we overflow? We >> could then make a note about it in process accounting docs. We might want >> to fix this in rusage as well. > > Encoding LONG_MAX and issuing a printf warning is I think a reasonable > solution. I'll be away from a broadband connection until Friday, so if > anybody else wants to commit this, go ahead. Otherwise I can do it over the > coming weekend. I'm pretty maxed out here right now, so certainly won't get to it sooner, so if you don't mind doing it this weekend, that would be good. Robert N M Watson Computer Laboratory University of Cambridge